Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{AKS} Support updating SSH public key with az aks update --ssh-key-value #5464

Merged
merged 1 commit into from
Oct 20, 2022
Merged

{AKS} Support updating SSH public key with az aks update --ssh-key-value #5464

merged 1 commit into from
Oct 20, 2022

Conversation

bingosummer
Copy link
Member

@bingosummer bingosummer commented Oct 18, 2022 •
edited
Loading

Related command

az aks update --ssh-key-value

@ghost ghost requested review from zhoxing-ms and wangzelin007 October 18, 2022 14:08
@ghost ghost assigned zhoxing-ms Oct 18, 2022
@ghost ghost added this to the Oct 2022 (2022-11-01) milestone Oct 18, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Oct 18, 2022
@ghost ghost requested a review from yonzhan October 18, 2022 14:08
@ghost ghost added the AKS label Oct 18, 2022
@bingosummer bingosummer changed the title Support updating SSH public key with az aks update --ssh-key {AKS} Support updating SSH public key with az aks update --ssh-key Oct 18, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 18, 2022

AKS

@bingosummer bingosummer force-pushed the aks-update-ssh-key branch 6 times, most recently from f43201a to 270adff Compare October 19, 2022 08:11
@bingosummer
Copy link
Member Author

The pipeline passed.

@bingosummer bingosummer marked this pull request as ready for review October 19, 2022 08:24
FumingZhang
FumingZhang approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bingosummer bingosummer changed the title {AKS} Support updating SSH public key with az aks update --ssh-key {AKS} Support updating SSH public key with az aks update --ssh-key-value Oct 19, 2022
@bingosummer
Copy link
Member Author

@zhoxing-ms , thanks for your kindly reviews! Could you please take a look again?

@zhoxing-ms zhoxing-ms merged commit d1a9d16 into Azure:main Oct 20, 2022
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=10137&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karataliu karataliu karataliu left review comments

@FumingZhang FumingZhang FumingZhang approved these changes

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@wangzelin007 wangzelin007 Awaiting requested review from wangzelin007

@yonzhan yonzhan Awaiting requested review from yonzhan

@andyliuliming andyliuliming Awaiting requested review from andyliuliming andyliuliming is a code owner

Assignees

@zhoxing-ms zhoxing-ms

Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Milestone
Oct 2022 (2022-11-01)
Development

Successfully merging this pull request may close these issues.
6 participants
@bingosummer @yonzhan @azclibot @karataliu @zhoxing-ms @FumingZhang