Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} add support to create cluster with kube-proxy configuration #5427

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

mattstam
Copy link
Contributor

@mattstam mattstam commented Oct 7, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create --kube-proxy-config file.json

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 October 7, 2022 18:43
@ghost ghost assigned zhoxing-ms Oct 7, 2022
@ghost ghost added this to the Oct 2022 (2022-11-01) milestone Oct 7, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Oct 7, 2022
@ghost ghost requested a review from yonzhan October 7, 2022 18:44
@ghost ghost added the AKS label Oct 7, 2022
@mattstam mattstam force-pushed the mattstam/kubeproxyconfig-create branch from 086e41c to efa11e5 Compare October 7, 2022 18:45
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 8, 2022

AKS

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint issues scanned by CI.

Also need to rebase from main (including this change) to fix failures in Integration Tests, Build Tests....

@mattstam mattstam force-pushed the mattstam/kubeproxyconfig-create branch from efa11e5 to b4b2cf1 Compare October 8, 2022 08:55
@mattstam
Copy link
Contributor Author

mattstam commented Oct 8, 2022

Please the lint issues scanned by CI.

Also need to rebase from main (including this change) to fix failures in Integration Tests, Build Tests....

Rebased with main.

Locally I see some lint issue but they are not related to any of my changes from what I can tell, I think main just has lint issues in it?

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FumingZhang
Copy link
Member

Please the lint issues scanned by CI.
Also need to rebase from main (including this change) to fix failures in Integration Tests, Build Tests....

Rebased with main.

Locally I see some lint issue but they are not related to any of my changes from what I can tell, I think main just has lint issues in it?

Yeah, if the CI could pass, that would be fine.

@mattstam
Copy link
Contributor Author

mattstam commented Oct 8, 2022

Azure.azure-cli-extensions (CLI Linter on Modified Extensions)

azure-cli-extensions (CLI Linter on Modified Extensions) would be the relevant CI here, right? That seems to pass. If there is any other changes needed, please let me know.

@FumingZhang
Copy link
Member

FumingZhang commented Oct 9, 2022

Hey @mattstam, there are some errors in Azure.azure-cli-extensions (Static Analysis) need to be fixed.

/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:92:1: E302 expected 2 blank lines, found 1
/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:397:1: W293 blank line contains whitespace
/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:2392:45: E221 multiple spaces before operator

Besides, there's another NRP API version update in official CLI, which leads to the errors in Integration Tests, Build Tests..., fixing this in PR #5434. Please rebase from main later.

@mattstam mattstam force-pushed the mattstam/kubeproxyconfig-create branch from b4b2cf1 to 881284c Compare October 10, 2022 17:13
@mattstam
Copy link
Contributor Author

Hey @mattstam, there are some errors in Azure.azure-cli-extensions (Static Analysis) need to be fixed.

/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:92:1: E302 expected 2 blank lines, found 1
/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:397:1: W293 blank line contains whitespace
/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:2392:45: E221 multiple spaces before operator

Besides, there's another NRP API version update in official CLI, which leads to the errors in Integration Tests, Build Tests..., fixing this in PR #5434. Please rebase from main later.

Thanks @FumingZhang, I have rebased with main and fixed all the lint issues in the AKS extension (including existing ones not related to the changes in this PR).

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms zhoxing-ms merged commit f5ac6be into Azure:main Oct 11, 2022
@azclibot
Copy link
Collaborator

azclibot commented Oct 11, 2022

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=8169&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants