-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ssh] Bug Fix: Change how ssh vm reads the ssh client logs #5366
Conversation
… redirected, but credentials need to be deleted, wait 2 minutes
ssh |
src/ssh/HISTORY.md
Outdated
1.1.3 | ||
----- | ||
* Fix bug where extension prints ssh banners after the connection is closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to release a new extension version, please also upgrade the version defined in setup.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoxing-ms I was planning on upgrading the version only after all the open PRs for the next release are merged and I have the chance to run some final tests. For now I'll just remove the changes in the HISTORY.md file for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vthiebaut10 OK. Or I can merge this PR first, and you can add new content to the history notes of subsequent PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, if you do not want to release a new version immediately, I suggest you add comments in PR to tell us
Fix: #4915 (comment)
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json
.