Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ssh] Bug Fix: Change how ssh vm reads the ssh client logs #5366

Merged
merged 10 commits into from
Oct 21, 2022

Conversation

vthiebaut10
Copy link
Contributor

Fix: #4915 (comment)

  • ssh vm reads the logs from ssh client and ssh proxy to delete sensitive information when it is no longer needed and print helpful error messages for known errors. Our approach to do that was causing ssh banners to be printed after the ssh process was terminated, and not before authentication.
  • Known issue: we are no longer able to read ssh proxy error channel when the user is running the command from a linux machine to connect to a local user on an arc machine. That is not a breaking change, but users in this particular situation will not get a helpful error message if there is an error with the proxy.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from yonzhan and zhoxing-ms September 19, 2022 23:07
@ghost ghost added the Auto-Assign Auto assign by bot label Sep 19, 2022
@ghost ghost requested a review from wangzelin007 September 19, 2022 23:07
@ghost ghost assigned zhoxing-ms Sep 19, 2022
@ghost ghost added this to the Sep 2022 (2022-10-12) - For Ignite milestone Sep 19, 2022
@ghost ghost added the Compute label Sep 19, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 19, 2022

ssh

Comment on lines 3 to 5
1.1.3
-----
* Fix bug where extension prints ssh banners after the connection is closed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to release a new extension version, please also upgrade the version defined in setup.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhoxing-ms I was planning on upgrading the version only after all the open PRs for the next release are merged and I have the chance to run some final tests. For now I'll just remove the changes in the HISTORY.md file for this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vthiebaut10 OK. Or I can merge this PR first, and you can add new content to the history notes of subsequent PRs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, if you do not want to release a new version immediately, I suggest you add comments in PR to tell us

@zhoxing-ms zhoxing-ms merged commit c6a57d5 into Azure:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Compute
Projects
None yet
Development

Successfully merging this pull request may close these issues.

az ssh extension no longer displaying SSH banner correctly as of v1.1.1
3 participants