Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{k8s-extension} fixes Azure/azure-cli-extensions#5356 #5359

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

navba-MSFT
Copy link
Contributor

CLI Command: az k8s-extension extension-types list -g {} --cluster-name {} --cluster-type {}

Results in below error:
File "/opt/homebrew/Cellar/azure-cli/2.40.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/init.py", line 726, in _run_jobs_serially
results.append(self._run_job(expanded_arg, cmd_copy))
File "/opt/homebrew/Cellar/azure-cli/2.40.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/init.py", line 697, in _run_job
result = cmd_copy(params)
File "/opt/homebrew/Cellar/azure-cli/2.40.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/init.py", line 333, in call
return self.handler(*args, **kwargs)
File "/opt/homebrew/Cellar/azure-cli/2.40.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 112, in handler
client = self.client_factory(self.cli_ctx, command_args) if self.client_factory else None
File "/Users/tbock/.azure/cliextensions/k8s-extension/azext_k8s_extension/_client_factory.py", line 21, in cf_k8s_cluster_extension_types_operation
return cf_k8s_extension(cli_ctx, consts.EXTENSION_TYPE_API_VERSION).cluster_extension_types
TypeError: cf_k8s_extension() takes 1 positional argument but 2 were given

This PR fixes this issue.

fixes #5356


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

CLI Command: az k8s-extension extension-types list -g {} --cluster-name {} --cluster-type {}

Results in below error:
  File "/opt/homebrew/Cellar/azure-cli/2.40.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/homebrew/Cellar/azure-cli/2.40.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 697, in _run_job
    result = cmd_copy(params)
  File "/opt/homebrew/Cellar/azure-cli/2.40.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 333, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/homebrew/Cellar/azure-cli/2.40.0/libexec/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 112, in handler
    client = self.client_factory(self.cli_ctx, command_args) if self.client_factory else None
  File "/Users/tbock/.azure/cliextensions/k8s-extension/azext_k8s_extension/_client_factory.py", line 21, in cf_k8s_cluster_extension_types_operation
    return cf_k8s_extension(cli_ctx, consts.EXTENSION_TYPE_API_VERSION).cluster_extension_types
TypeError: cf_k8s_extension() takes 1 positional argument but 2 were given

This PR fixes this issue.

fixes Azure#5356
@ghost ghost requested a review from yonzhan September 16, 2022 05:22
@ghost ghost added the Auto-Assign Auto assign by bot label Sep 16, 2022
@ghost ghost requested a review from zhoxing-ms September 16, 2022 05:22
@ghost ghost assigned zhoxing-ms Sep 16, 2022
@ghost ghost added this to the Sep 2022 (2022-10-12) - For Ignite milestone Sep 16, 2022
@ghost ghost requested a review from wangzelin007 September 16, 2022 05:22
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 16, 2022

k8s-extension

@navba-MSFT navba-MSFT added bug This issue requires a change to an existing behavior in the product in order to be resolved. Code Gen labels Sep 16, 2022
@zhoxing-ms
Copy link
Contributor

Could you add some tests for this command?

@zhoxing-ms
Copy link
Contributor

Please add the description of this PR in HISTORY.rst. If you want to release a new extension version for this PR, please also upgrade the version in setup.py

@zhoxing-ms zhoxing-ms merged commit ef135c0 into Azure:main Sep 19, 2022
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ k8s-extension ] : https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1858181&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot bug This issue requires a change to an existing behavior in the product in order to be resolved. Code Gen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

az k8s-extension extension-types list failed
4 participants