Force delete functionality to remove any hanging resources #5282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: src/connectedk8s/azext_connectedk8s/_params.py modified: src/connectedk8s/azext_connectedk8s/_utils.py modified: src/connectedk8s/azext_connectedk8s/custom.py new file: src/connectedk8s/azext_connectedk8s/patch-file.yaml
|
connectedk8s |
modified: src/connectedk8s/azext_connectedk8s/_utils.py modified: src/connectedk8s/azext_connectedk8s/custom.py
modified: src/connectedk8s/azext_connectedk8s/custom.py
|
This functionality is added to remove any hanging resources from the connected cluster if the config map is missing or namespace "azure-arc" itself gets deleted . This function does the work of deletion of resources without using any hooks |
zhoxing-ms
reviewed
Aug 30, 2022
zhoxing-ms
reviewed
Aug 31, 2022
sirireddy12
reviewed
Sep 1, 2022
modified: src/connectedk8s/azext_connectedk8s/commands.py modified: src/connectedk8s/azext_connectedk8s/custom.py new file: src/connectedk8s/azext_connectedk8s/tests/latest/recordings/test_forcedelete.yaml modified: src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py
sirireddy12
reviewed
Sep 1, 2022
sirireddy12
reviewed
Sep 1, 2022
sirireddy12
reviewed
Sep 1, 2022
yonzhan
modified the milestones:
Aug 2022 (2022-09-06),
Sep 2022 (2022-10-12) - For Ignite
sirireddy12
reviewed
Sep 2, 2022
sirireddy12
reviewed
Sep 2, 2022
modified: src/connectedk8s/azext_connectedk8s/custom.py renamed: src/connectedk8s/azext_connectedk8s/patch-file.yaml -> src/connectedk8s/azext_connectedk8s/remove_crd_finalizer.yaml modified: src/connectedk8s/azext_connectedk8s/tests/latest/recordings/test_forcedelete.yaml modified: src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py
modified: src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py
|
sirireddy12
reviewed
Sep 2, 2022
modified: src/connectedk8s/azext_connectedk8s/custom.py
modified: src/connectedk8s/setup.py
zhoxing-ms
approved these changes
Sep 5, 2022
wangzelin007
approved these changes
Sep 5, 2022
|
[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1830394&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.