Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Traffic Collector] Add az network-function traffic-collector CLI #5263

Merged

Conversation

rmodh
Copy link
Contributor

@rmodh rmodh commented Aug 22, 2022

Resolves Azure/azure-cli#22270


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Aug 22, 2022
@ghost
Copy link

ghost commented Aug 22, 2022

Thank you for your contribution rmodh! We will review the pull request and get back to you soon.

@ghost ghost requested review from yonzhan, jsntcy and kairu-ms August 22, 2022 20:45
@ghost ghost added the Auto-Assign Auto assign by bot label Aug 22, 2022
@ghost ghost requested review from wangzelin007 and necusjz August 22, 2022 20:45
@ghost ghost assigned necusjz Aug 22, 2022
@ghost ghost added this to the Aug 2022 (2022-09-06) milestone Aug 22, 2022
@ghost ghost added the Network label Aug 22, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 22, 2022

traffic collector

@rmodh rmodh force-pushed the feature-add-azure-traffic-collector-cmdlets branch 2 times, most recently from 70b4881 to b259252 Compare August 30, 2022 20:41
@rmodh rmodh marked this pull request as ready for review August 30, 2022 21:15
@rmodh rmodh changed the title Add command model for az network-function traffic-collector AB#15187084 Add command model for az network-function traffic-collector Sep 1, 2022
@rmodh rmodh changed the title AB#15187084 Add command model for az network-function traffic-collector AB#15187084 Sep 1, 2022
@rmodh rmodh changed the title AB#15187084 AB#15187084 Add command model for az network-function traffic-collector Sep 1, 2022
@rmodh rmodh force-pushed the feature-add-azure-traffic-collector-cmdlets branch from b259252 to 9e1c309 Compare September 1, 2022 23:49
@rmodh rmodh requested review from kairu-ms and removed request for necusjz, jsntcy, wangzelin007 and yonzhan September 2, 2022 00:28
@rmodh rmodh force-pushed the feature-add-azure-traffic-collector-cmdlets branch from 9e1c309 to 4baa87e Compare September 2, 2022 00:37
@rmodh rmodh force-pushed the feature-add-azure-traffic-collector-cmdlets branch from 98e7152 to 9ddd0cd Compare September 2, 2022 05:11
@rmodh rmodh requested a review from kairu-ms September 2, 2022 05:38
src/service_name.json Outdated Show resolved Hide resolved
@necusjz necusjz changed the title AB#15187084 Add command model for az network-function traffic-collector [Traffic Connector] Add az network-function traffic-collector CLI Sep 5, 2022
@rmodh rmodh force-pushed the feature-add-azure-traffic-collector-cmdlets branch from 9ddd0cd to fe28edf Compare September 6, 2022 22:35
@rmodh rmodh requested review from necusjz and kairu-ms and removed request for kairu-ms and necusjz September 6, 2022 22:40
@necusjz necusjz merged commit 764d595 into Azure:main Sep 7, 2022
@azclibot
Copy link
Collaborator

azclibot commented Sep 7, 2022

[Release] Update index.json for extension [ traffic-collector ] : https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1834390&view=results

@rmodh rmodh changed the title [Traffic Connector] Add az network-function traffic-collector CLI [Traffic Collector] Add az network-function traffic-collector CLI Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization. Network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Traffic Collector CLI
6 participants