Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Automation Hybrid Worker resource commands added #5261

Merged
merged 9 commits into from
Aug 24, 2022

Conversation

krmanupa
Copy link
Contributor

@krmanupa krmanupa commented Aug 22, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az automation hrwg create
az automation hrwg delete
az automation hrwg list
az automation hrwg show
az automation hrwg update

az automation hrwg hrw create
az automation hrwg hrw delete
az automation hrwg hrw list
az automation hrwg hrw move
az automation hrwg hrw show
az automation hrwg hrw update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
    no errors in the files added as part of this PR
  • Have you run python scripts/ci/test_index.py -q locally?
    Yes, no errors were seen

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@krmanupa krmanupa requested a review from zhoxing-ms as a code owner August 22, 2022 14:58
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Aug 22, 2022
@ghost
Copy link

ghost commented Aug 22, 2022

Thank you for your contribution krmanupa! We will review the pull request and get back to you soon.

@krmanupa krmanupa changed the title Azure Automation Hybrid Worker Group resource commands added Azure Automation Hybrid Worker resource commands added Aug 22, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 22, 2022

Automation

@zhoxing-ms
Copy link
Contributor

Please write the description of those new features into HISTORY.rst. In addition, if you want to release a new version of extension for this PR, please also modify the version defined in setup.py.

@zhoxing-ms
Copy link
Contributor

@kairu-ms Since this PR is generated by Code Gen v2, do you need to review it from the perspective of Code Gen expert?

@zhoxing-ms
Copy link
Contributor

@krmanupa Please address this CLI linter issue

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Aug 23, 2022

az automation hybrid-runbook-worker-group hybrid-runbook-worker create
az automation hybrid-runbook-worker-group hybrid-runbook-worker delete
az automation hybrid-runbook-worker-group hybrid-runbook-worker list
az automation hybrid-runbook-worker-group hybrid-runbook-worker move
az automation hybrid-runbook-worker-group hybrid-runbook-worker show
az automation hybrid-runbook-worker-group hybrid-runbook-worker update

It seems that hybrid-runbook-worker has repeated the command naming. Could you refine and simplify it?

_args_schema.credential = AAZObjectArg(
options=["--credential"],
arg_group="Properties",
help="Sets the credential of a worker group.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use the first person voice in the help message

Suggested change
help="Sets the credential of a worker group.",
help="Set the credential of a worker group.",

@zhoxing-ms
Copy link
Contributor

Please address this CLI linter issue

You can use options_list to declare a short alias for the parameter, or declare the check exclusion for this parameter in the linter_exclusions.yml file

@zhoxing-ms zhoxing-ms merged commit 76182a6 into Azure:main Aug 24, 2022
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ automation ] : https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1803541&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants