[Spring] Add pricing tier validator for command group az spring app-insights #5053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
spring |
jiec-msft
force-pushed
the
mason/fix_update_ai_in_enterprise_tier
branch
from
5a263a6 to
3f05d2e
Compare
jiec-msft
force-pushed
the
mason/fix_update_ai_in_enterprise_tier
branch
from
3f05d2e to
f7db37e
Compare
jiec-msft
changed the title
ShichaoQiu
approved these changes
Jul 5, 2022
zhoxing-ms
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Commands
az spring app-insights update/showonly support Basic/Standard tier, not support Enterprise tier. To avoid confusing error message customer may get when use these commands against enterprise tier, add tier validator to throw customer error.Related commands
az spring app-insights update xxxaz spring app-insights show xxxInternal test
https://msazure.visualstudio.com/AzureDMSS/_build/results?buildId=57323066&view=results
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.