[Blueprint] Prevent hidden artifacts parsing #4985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
customer-reported
|
Thank you for your contribution simonkeyd! We will review the pull request and get back to you soon. |
|
|
|
Blueprint |
jsntcy
reviewed
Jun 21, 2022
|
@simonkeyd, please take a look at my comments. |
Blueprint extension was parsing all files in the artifacts folder including hidden files. This unwanted behavior can also raise errors (eg. UnicodeDecodeError). This commit fixes this by preventing hidden Linux and Windows files from being parsed. closes Azure#4984
simonkeyd
force-pushed
the
fix/prevent-blueprint-hidden-files-parsing
branch
from
b99b68e to
5392ed0
Compare
|
@jsntcy I amended my commit according to your suggestions. The code is now working for both Windows and Linux platforms. For Linux only it checks for files with a name starting with a dot and for Windows it excludes files with the hidden attribute. |
jsntcy
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blueprint extension was parsing all files in the artifacts folder
including hidden Linux files. This unwanted behavior could also raise
errors (eg. UnicodeDecodeError). This commit fixes this by preventing
hidden files from being parsed.
closes #4984
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az blueprint import --name generic_blueprint --input-path ./generic_blueprint --management-group deadbeef-dead-beef-8badf00d1337
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.