[appservice-kube] az functionapp create: Make --storage-account optional for Kubernetes function apps
#4678
Conversation
ghost
added
the
ghost
requested review from
|
appservice-kube |
|
FYI @ lpapudippu |
|
@StrawnSC, |
|
@StrawnSC added do not merge label for now, since there is some confusion, that feature team wants to test this with private whl, before releasing. you are on the group chat as well, lets merge this once we get conformation from them. Thanks! |
|
@zhoxing-ms could we get this released soon as well? Thanks! |
| @@ -18,6 +18,7 @@ class AppserviceKubernetesScenarioTest(ScenarioTest): | |||
|
|
|||
| # not lima-specific | |||
| class WebappBasicE2EKubeTest(ScenarioTest): | |||
| @live_only() | |||
There was a problem hiding this comment.
Why do you mark this test as @live_only()?
There was a problem hiding this comment.
This test passes locally (run live or as a recording), but fails in the CI with: vcr.errors.CannotOverwriteExistingCassetteException. I just pushed the recording for this test and removed the live_only and now the tests are failing
There was a problem hiding this comment.
ERROR: Can't overwrite existing cassette ('/home/vsts/work/1/s/src/appservice-kube/azext_appservice_kube/tests/latest/recordings/test_linux_webapp_quick_create_kube.yaml') in your current record mode ('once').
No match for the request (<Request (POST) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Web/validate?api-version=2021-03-01>) was found.
Found 6 similar requests with 1 different matcher(s) :
This problem is caused by the fact that a rest request for validation is not recorded in the yaml file
There was a problem hiding this comment.
@StrawnSC I guess this may be because the code used in the local tests is not up to date.
Could you please pull the latest code from CLI main repo for main CLI code to the local, and then try to re-record the yaml file?
There was a problem hiding this comment.
I'm pretty sure I was using the latest version of the main CLI's dev branch. I'll try again just to be sure
There was a problem hiding this comment.
@zhoxing-ms it's still failing in the CI even when I use the latest code for the main CLI (and rerun azdev setup)
There was a problem hiding this comment.
This testing issue seems unrelated to this change: the change was to az functionapp create whereas the test that passes locally but fails in the CI is testing az webapp create. Also, we've been getting requests from the function apps team to release this for a while. Can I go ahead and mark the test as live_only for now so we can release this?
There was a problem hiding this comment.
@StrawnSC OK, if you are sure that this problem does not affect the feature of this PR, you can mark the test as live_only to avoid blocking the merging of PR. You can solve the test problems in the follow-up PR
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.