Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karenchen/enable draftv2 #4651

Merged
merged 78 commits into from
May 23, 2022
Merged

Conversation

karenychen
Copy link
Contributor

@karenychen karenychen commented Apr 7, 2022


This is an extension for DraftV2. We have created a new feature branch as Marcus is away for the rest of the week
DraftV2 Repo
DraftV2 Design Dock

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@karenychen karenychen marked this pull request as ready for review April 7, 2022 16:31
@karenychen karenychen changed the title Karenchen/enable draftv2 (WIP) Karenchen/enable draftv2 Apr 7, 2022
@Tatsinnit
Copy link
Member

Tatsinnit commented May 21, 2022

💡 Hope this helps: seems like there is a cassette file with this checkin, fyi @FumingZhang in case he notices something and if more help is in need from this feature end, as to why this test is failing. Here are few things I noticed.

cc: @karenychen, fyi: @qpetraroia 🙏☕️

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued a pipeline to test the newly added cases.

Found some problems with concurrent execution. These test cases all try to modify (download)/use the binary in the same location.

@qpetraroia
Copy link

@FumingZhang ready for you to merge when you can 😀

@karenychen karenychen requested a review from FumingZhang May 23, 2022 09:25
@FumingZhang
Copy link
Member

Queued another pipeline to verify test cases. All test cases passed.

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms zhoxing-ms merged commit 229a1cf into Azure:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants