-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karenchen/enable draftv2 #4651
Karenchen/enable draftv2 #4651
Conversation
…ng other issues with whitespace, and unused variables
💡 Hope this helps: seems like there is a
cc: @karenychen, fyi: @qpetraroia 🙏☕️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queued a pipeline to test the newly added cases.
Found some problems with concurrent execution. These test cases all try to modify (download)/use the binary in the same location.
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
@FumingZhang ready for you to merge when you can 😀 |
Queued another pipeline to verify test cases. All test cases passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is an extension for DraftV2. We have created a new feature branch as Marcus is away for the rest of the week
DraftV2 Repo
DraftV2 Design Dock
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.