Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rsamigullin/addstartnodepool commands #3990

Merged
merged 17 commits into from
Oct 25, 2021
Merged

Rsamigullin/addstartnodepool commands #3990

merged 17 commits into from
Oct 25, 2021

Conversation

rsamigullin
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 19, 2021

aks

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please resolve the conflicts with main branch 😃

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Oct 21, 2021

@rsamigullin Could you write the description of these changes in HISTORY.rst? By the way, if you want to upgrade the extension version to release this change, please update the setup.py

@FumingZhang
Copy link
Member

As a reminder, the latest version has been updated to 0.5.38 and you may take 0.5.39

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zhoxing-ms zhoxing-ms merged commit d9d731f into Azure:main Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants