Add support for oauth connection management in botservice #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
williexu
suggested changes
Jun 21, 2018
| skype_channel ../botservice\models\azure_bot_service_enums.py /^ skype_channel = "SkypeChannel"$/;" kind:variable line:43 | ||
| skype_channel.py ../botservice\models\skype_channel.py 1;" kind:file line:1 | ||
| skype_channel_properties.py ../botservice\models\skype_channel_properties.py 1;" kind:file line:1 | ||
| skype_create ../custom.py /^def skype_create(client, resource_group_name, resource_name, is_disabled=None, enable_messa |
There was a problem hiding this comment.
vs code inserts this for some reason. i will remove it
There was a problem hiding this comment.
aah generated by vscode for some reason. i will remove it. it always regenerates it every time i open the code base in vscode.
src/botservice/azext_bot/_help.py
Outdated
| type: command | ||
| short-summary: Delete an OAuth Connection Setting on a Bot. | ||
| """ | ||
| helps['bot connection listproviders'] = """ |
src/botservice/azext_bot/_help.py
Outdated
| @@ -119,6 +119,30 @@ | |||
| type: command | |||
| short-summary: Create Slack Channel on a Bot. | |||
| """ | |||
| helps['bot connection'] = """ | |||
| type: command | |||
src/botservice/azext_bot/commands.py
Outdated
| g.custom_command('show', 'get_connection') | ||
| g.custom_command('create', 'create_connection') | ||
| g.custom_command('delete', 'delete_connection') | ||
| g.custom_command('listproviders', 'get_service_providers') |
There was a problem hiding this comment.
list-providers is more aligned with the rest of the CLI's commands.
| @@ -62,7 +62,7 @@ def create( | |||
| # Construct URL | |||
| url = '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/botServices/{resourceName}' | |||
| path_format_arguments = { | |||
| 'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str'), | |||
| 'resourceGroupName': self._serialize.url("resource_group_name", resource_group_name, 'str', max_length=64, min_length=2, pattern=r'^[a-zA-Z0-9][a-zA-Z0-9_.-]*$'), | |||
There was a problem hiding this comment.
Is this newly generated from autorest? or are these manual changes?
There was a problem hiding this comment.
newly generated from autorest. i added some validation to the resource group parameter in the swagger , so it showed up here
src/botservice/azext_bot/_params.py
Outdated
| c.argument('parameters', help='parameter values for Service Provider Parameters. Usage: --parameters key=value key1=value1', nargs='+') | ||
|
|
||
| with self.argument_context('bot connection listproviders') as c: | ||
| c.argument('as_raw_settings', options_list=['--asraw'], help='Output the raw json for each service provider', arg_type=get_three_state_flag()) |
There was a problem hiding this comment.
options_list=['--as-raw']
williexu
approved these changes
Jun 26, 2018
belmaiastar
added a commit
to belmaiastar/azure-cli-extensions
that referenced
this pull request
Jul 20, 2018
* Remove rdbms public CLI extension. (Azure#179) * Worm feature and listing usage by region (Azure#181) * vendored mgmt sdk * sdk * updated old recordings for new sdk * added worm feature enable listing usage by region ci fixes fixes fixes flake8 fixes removed prints * address feedback * updated index with new extension path * version bump in index * Updating the dev-spaces command from aks group to ads group (Azure#183) * Updating the dev-spaces command from aks group to ads group - refactoring * Installing cli tooling, if does not exist, on remove command * Updating min req of azure cli to 2.0.32 * Reverting index related changes - will send out a separate PR for this, after updating the generated whl file. * Updating index: sha and minCliVersion (Azure#185) * iotext v0.4.5 (Azure#188) * iotext v0.4.5 * Fix sha256 hash. * Bumping Dev Spaces version to 0.1.1 and updating the Index (Azure#186) * VNET extension (Azure#176) * VNET extension Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later . * fixing indentation fixing indentation * fixing more flake8 reported issues fixing more flake8 reported issues * Fixing Review comments and formatting issues. Fixing Review comments and formatting issues. * Fixing some more issues with source static and bug fixes Fixing some more issues with source static and bug fixes * Renaming _client_factory to _client_vnet_factory Renaming _client_factory to _client_vnet_factory * Reverting the last change Reverting the last change * Renaming to azext_rdbms_vnet Renaming to azext_rdbms_vnet * More formatting issue fix More formatting issue fix * adding code owners adding code owners * Adding my email id Adding my email id :) * Adding extension to index.json wheel file is already uploaded to prodrdbmsclipackages * fixing index-verify fixing index-verify * Changed the default value for eventdeliveryschema parameter to match the input event schema. (Azure#189) * Added eventgrid preview extension to index.json. * Made the hash lowercase. * Regenerated using Wheel 0.30 * Updating index metadata to match with what's in the package. * Updated the description to match what's in the package. * Added minCliCoreVersion in index.json to match with the metadata in the package. * Changed the default value for eventdeliveryschema parameter to match the input event schema. * Updated version in index.json and fixed the default in the function argument list. * Changing SHA256digest to lower case. * Regenerated extension with 0.30.0 of wheel to resolve CI errors. * Updating space select functionality (Azure#191) * Updating space select - selecting space on resource create/select both - updating azds osx url * Update * CR * Adding comments * CR * Management policy and new api-version (Azure#194) * added new apiversion for mgmt sdk * updated storage mgmt client for new api * updated sdk and most recordings except show usage * finalized commands * usage to usages and help * fixed excryption tests * static check * updated help * Management policy recording and new version of wheel (Azure#195) * updated some recordings * added new wheel to index * project url * updated whl * update index.json with new botservice package(minor fixes) (Azure#199) * update index.json with new botservice package(minor fixes) * update version on index.json to match the new package * Updating dev-spaces-preview extension to honor azds commands update (Azure#196) * Updating dev-spaces-preview extension to honor azds commands update * Adding update option to force install the newer version of azds tool * Update remove command * Index Update * Image-Copy: add support for sources backup by vhd files and snapshots (Azure#201) * update descriptions and version * Add checks to verify that the source has a managed disk * fix procedure to name the temp storage account * support tags and final image name * fix lint issue * remove debug statement * add version 0.0.6 to index * support sources backed by vhd blobs (copied images) and snapshots * fix how we find the source_os_disk_id * adding image-copy version 0.0.7 to the index * fix issue with publishing to bot (Azure#202) * fix missing client error during publish * update index.json * remove unused client variable * Updating some params of use command (Azure#200) * Updating some params of use command * Updating index and bumping version * Removing commands and just keeping the module library to be accessed by azure cli * Index update * disable=too-few-public-methods * extend alotted time for script in travis (Azure#208) * extend alotted time for script in travis * longer CI times for surcetests * Updates to extension documentation (Azure#210) * doc for vendored_sdks folder * add README to point at extension docs in azure-cli folder * forgot to add docs readme * DMS - Adding PG and MySQL extension (Azure#207) * Added functionality for Data Migration Assistant * Renamed extension * Updated the default database for PG * Updated the extension description to remove any CLI references * Renamed 'mgmt' to 'vendored_sdks' * Fixed pylint issues * extend alotted time for script in travis * Fixed flake8 test results * Updated code owners * Added metadata * Added license headers * added information to storage-preview extension readme for included features (Azure#212) * Updating az use call to azds cli (Azure#211) * Updating az use call to azds cli - addressing azds updated cli * Fix indentation error * update * Update * CR: renaming the prompt variable * readme changes (Azure#214) * Updating output messages to be printed in default mode (Azure#215) * Updating output messages to be printed in default mode * Code Review Update * increase travis wait time for source tests * Add support for oauth connection management in botservice (Azure#213) * add support for oauth to botservice cli * minor fixes * fix style warnings * more pylint error fixes * fix flake errors * addressed comments. bumped up version * Static web and hierarchical namespace features. (Azure#218) * updated sdk * service-properties update * initial generic update for blob service-properties * implemented generic update for service props * added testing and recording update * fixed bug * added test * recording * updated mgmt sdk for storage * added hierarchical namespace feature to account create * version bump * ci * pylint and re-recorded all tests * updated all recordings and tests for new sdks * IoT extension release 0.5.0 (Azure#219) * IoT extension release 0.5.0 * fix dep format issue * change order of index dependencies * Index storage 0.1.3 (Azure#220) * index storage * index edits * added examples and new features (Azure#221) * updated api-version of arm to cli (Azure#222) * updated api-version of arm to cli * converted all api-versions for resource * Update batch extension to 2.3.0 (Azure#225) * changes to dependency check (Azure#226) * changes to dependency check * CI * Fixed: can not connect when using slot option. (Azure#227)
belmaiastar
pushed a commit
to belmaiastar/azure-cli-extensions
that referenced
this pull request
Jul 20, 2018
* Remove rdbms public CLI extension. (Azure#179) * Worm feature and listing usage by region (Azure#181) * vendored mgmt sdk * sdk * updated old recordings for new sdk * added worm feature enable listing usage by region ci fixes fixes fixes flake8 fixes removed prints * address feedback * updated index with new extension path * version bump in index * Updating the dev-spaces command from aks group to ads group (Azure#183) * Updating the dev-spaces command from aks group to ads group - refactoring * Installing cli tooling, if does not exist, on remove command * Updating min req of azure cli to 2.0.32 * Reverting index related changes - will send out a separate PR for this, after updating the generated whl file. * Updating index: sha and minCliVersion (Azure#185) * iotext v0.4.5 (Azure#188) * iotext v0.4.5 * Fix sha256 hash. * Bumping Dev Spaces version to 0.1.1 and updating the Index (Azure#186) * VNET extension (Azure#176) * VNET extension Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later . * fixing indentation fixing indentation * fixing more flake8 reported issues fixing more flake8 reported issues * Fixing Review comments and formatting issues. Fixing Review comments and formatting issues. * Fixing some more issues with source static and bug fixes Fixing some more issues with source static and bug fixes * Renaming _client_factory to _client_vnet_factory Renaming _client_factory to _client_vnet_factory * Reverting the last change Reverting the last change * Renaming to azext_rdbms_vnet Renaming to azext_rdbms_vnet * More formatting issue fix More formatting issue fix * adding code owners adding code owners * Adding my email id Adding my email id :) * Adding extension to index.json wheel file is already uploaded to prodrdbmsclipackages * fixing index-verify fixing index-verify * Changed the default value for eventdeliveryschema parameter to match the input event schema. (Azure#189) * Added eventgrid preview extension to index.json. * Made the hash lowercase. * Regenerated using Wheel 0.30 * Updating index metadata to match with what's in the package. * Updated the description to match what's in the package. * Added minCliCoreVersion in index.json to match with the metadata in the package. * Changed the default value for eventdeliveryschema parameter to match the input event schema. * Updated version in index.json and fixed the default in the function argument list. * Changing SHA256digest to lower case. * Regenerated extension with 0.30.0 of wheel to resolve CI errors. * Updating space select functionality (Azure#191) * Updating space select - selecting space on resource create/select both - updating azds osx url * Update * CR * Adding comments * CR * Management policy and new api-version (Azure#194) * added new apiversion for mgmt sdk * updated storage mgmt client for new api * updated sdk and most recordings except show usage * finalized commands * usage to usages and help * fixed excryption tests * static check * updated help * Management policy recording and new version of wheel (Azure#195) * updated some recordings * added new wheel to index * project url * updated whl * update index.json with new botservice package(minor fixes) (Azure#199) * update index.json with new botservice package(minor fixes) * update version on index.json to match the new package * Updating dev-spaces-preview extension to honor azds commands update (Azure#196) * Updating dev-spaces-preview extension to honor azds commands update * Adding update option to force install the newer version of azds tool * Update remove command * Index Update * Image-Copy: add support for sources backup by vhd files and snapshots (Azure#201) * update descriptions and version * Add checks to verify that the source has a managed disk * fix procedure to name the temp storage account * support tags and final image name * fix lint issue * remove debug statement * add version 0.0.6 to index * support sources backed by vhd blobs (copied images) and snapshots * fix how we find the source_os_disk_id * adding image-copy version 0.0.7 to the index * fix issue with publishing to bot (Azure#202) * fix missing client error during publish * update index.json * remove unused client variable * Updating some params of use command (Azure#200) * Updating some params of use command * Updating index and bumping version * Removing commands and just keeping the module library to be accessed by azure cli * Index update * disable=too-few-public-methods * extend alotted time for script in travis (Azure#208) * extend alotted time for script in travis * longer CI times for surcetests * Updates to extension documentation (Azure#210) * doc for vendored_sdks folder * add README to point at extension docs in azure-cli folder * forgot to add docs readme * DMS - Adding PG and MySQL extension (Azure#207) * Added functionality for Data Migration Assistant * Renamed extension * Updated the default database for PG * Updated the extension description to remove any CLI references * Renamed 'mgmt' to 'vendored_sdks' * Fixed pylint issues * extend alotted time for script in travis * Fixed flake8 test results * Updated code owners * Added metadata * Added license headers * added information to storage-preview extension readme for included features (Azure#212) * Updating az use call to azds cli (Azure#211) * Updating az use call to azds cli - addressing azds updated cli * Fix indentation error * update * Update * CR: renaming the prompt variable * readme changes (Azure#214) * Updating output messages to be printed in default mode (Azure#215) * Updating output messages to be printed in default mode * Code Review Update * increase travis wait time for source tests * Add support for oauth connection management in botservice (Azure#213) * add support for oauth to botservice cli * minor fixes * fix style warnings * more pylint error fixes * fix flake errors * addressed comments. bumped up version * Static web and hierarchical namespace features. (Azure#218) * updated sdk * service-properties update * initial generic update for blob service-properties * implemented generic update for service props * added testing and recording update * fixed bug * added test * recording * updated mgmt sdk for storage * added hierarchical namespace feature to account create * version bump * ci * pylint and re-recorded all tests * updated all recordings and tests for new sdks * IoT extension release 0.5.0 (Azure#219) * IoT extension release 0.5.0 * fix dep format issue * change order of index dependencies * Index storage 0.1.3 (Azure#220) * index storage * index edits * added examples and new features (Azure#221) * updated api-version of arm to cli (Azure#222) * updated api-version of arm to cli * converted all api-versions for resource * Update batch extension to 2.3.0 (Azure#225) * changes to dependency check (Azure#226) * changes to dependency check * CI * Fixed: can not connect when using slot option. (Azure#227) * improved the deployment create command to now display back the public IP Addresses of the applications if available otherwise the status of the applications within the tempalte * added warning for when a network for an application can not be reached * added in displaying arm deployment errors * removed ~ folder * fixed the imports from client factory * removing files * specified errors and reduced clutter and depth of if statements * removed .vs * put in ascii friendly character * docs (Azure#228) * added better logic handling for errors and show running now * fixed import for http error from network client * changed setup.py to 0.9.0 and changed the deploying to not redisplay * removed the untested parts * fixed white space comma issue * updated version * added history.rst version * improved wording of history.rst * added more safety checks for getting network references. reduced duplicate checks for looping over applications. fixed outputting for a few different places * Automationstatic (Azure#232) * use flake8 config to apply exclusions, remove travis wait * pin pylint 1.9.2 for CI * fix link for extension summary for PRs (Azure#233) * Checks for license presence while disregarding '#\n' (Azure#237) * license ignore newlines * added licenses * cleanup * add static check as precheck (Azure#238) * add static check as precheck * made basic index verification part of precheck * added network ref parse ability for other common format * started adding validation precheck to deploying * now has validation error check first * changed len check of string * cleaned up output * fixed formatting * fixed formatting of EOF lines * removed logging statement * removed the no wait from validation because it didnt seem necessary * ref doc gen broken due to deprecation work (Azure#240) * should now just return expressions from the function and removed unused import * removed .idea files * should fix the inconsistent return formatting issue * added back missing new line * check_call will block child_process if enough output is sent to PIPE (Azure#243) * check_call will block child_process if enough output is sent to PIPE * run is unavailable in python2, opting for check_output which reads from the PIPE * remove PIPE * fixed client naming
williexu
pushed a commit
that referenced
this pull request
Jul 21, 2018
* Service Fabric Mesh - Public Preview (#22) * Mesh public preview (#26) * Private Preview 4 * Fix CI check * Use future print * Merge from master (#27) * Remove rdbms public CLI extension. (#179) * Worm feature and listing usage by region (#181) * vendored mgmt sdk * sdk * updated old recordings for new sdk * added worm feature enable listing usage by region ci fixes fixes fixes flake8 fixes removed prints * address feedback * updated index with new extension path * version bump in index * Updating the dev-spaces command from aks group to ads group (#183) * Updating the dev-spaces command from aks group to ads group - refactoring * Installing cli tooling, if does not exist, on remove command * Updating min req of azure cli to 2.0.32 * Reverting index related changes - will send out a separate PR for this, after updating the generated whl file. * Updating index: sha and minCliVersion (#185) * iotext v0.4.5 (#188) * iotext v0.4.5 * Fix sha256 hash. * Bumping Dev Spaces version to 0.1.1 and updating the Index (#186) * VNET extension (#176) * VNET extension Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later . * fixing indentation fixing indentation * fixing more flake8 reported issues fixing more flake8 reported issues * Fixing Review comments and formatting issues. Fixing Review comments and formatting issues. * Fixing some more issues with source static and bug fixes Fixing some more issues with source static and bug fixes * Renaming _client_factory to _client_vnet_factory Renaming _client_factory to _client_vnet_factory * Reverting the last change Reverting the last change * Renaming to azext_rdbms_vnet Renaming to azext_rdbms_vnet * More formatting issue fix More formatting issue fix * adding code owners adding code owners * Adding my email id Adding my email id :) * Adding extension to index.json wheel file is already uploaded to prodrdbmsclipackages * fixing index-verify fixing index-verify * Changed the default value for eventdeliveryschema parameter to match the input event schema. (#189) * Added eventgrid preview extension to index.json. * Made the hash lowercase. * Regenerated using Wheel 0.30 * Updating index metadata to match with what's in the package. * Updated the description to match what's in the package. * Added minCliCoreVersion in index.json to match with the metadata in the package. * Changed the default value for eventdeliveryschema parameter to match the input event schema. * Updated version in index.json and fixed the default in the function argument list. * Changing SHA256digest to lower case. * Regenerated extension with 0.30.0 of wheel to resolve CI errors. * Updating space select functionality (#191) * Updating space select - selecting space on resource create/select both - updating azds osx url * Update * CR * Adding comments * CR * Management policy and new api-version (#194) * added new apiversion for mgmt sdk * updated storage mgmt client for new api * updated sdk and most recordings except show usage * finalized commands * usage to usages and help * fixed excryption tests * static check * updated help * Management policy recording and new version of wheel (#195) * updated some recordings * added new wheel to index * project url * updated whl * update index.json with new botservice package(minor fixes) (#199) * update index.json with new botservice package(minor fixes) * update version on index.json to match the new package * Updating dev-spaces-preview extension to honor azds commands update (#196) * Updating dev-spaces-preview extension to honor azds commands update * Adding update option to force install the newer version of azds tool * Update remove command * Index Update * Image-Copy: add support for sources backup by vhd files and snapshots (#201) * update descriptions and version * Add checks to verify that the source has a managed disk * fix procedure to name the temp storage account * support tags and final image name * fix lint issue * remove debug statement * add version 0.0.6 to index * support sources backed by vhd blobs (copied images) and snapshots * fix how we find the source_os_disk_id * adding image-copy version 0.0.7 to the index * fix issue with publishing to bot (#202) * fix missing client error during publish * update index.json * remove unused client variable * Updating some params of use command (#200) * Updating some params of use command * Updating index and bumping version * Removing commands and just keeping the module library to be accessed by azure cli * Index update * disable=too-few-public-methods * extend alotted time for script in travis (#208) * extend alotted time for script in travis * longer CI times for surcetests * Updates to extension documentation (#210) * doc for vendored_sdks folder * add README to point at extension docs in azure-cli folder * forgot to add docs readme * DMS - Adding PG and MySQL extension (#207) * Added functionality for Data Migration Assistant * Renamed extension * Updated the default database for PG * Updated the extension description to remove any CLI references * Renamed 'mgmt' to 'vendored_sdks' * Fixed pylint issues * extend alotted time for script in travis * Fixed flake8 test results * Updated code owners * Added metadata * Added license headers * added information to storage-preview extension readme for included features (#212) * Updating az use call to azds cli (#211) * Updating az use call to azds cli - addressing azds updated cli * Fix indentation error * update * Update * CR: renaming the prompt variable * readme changes (#214) * Updating output messages to be printed in default mode (#215) * Updating output messages to be printed in default mode * Code Review Update * increase travis wait time for source tests * Add support for oauth connection management in botservice (#213) * add support for oauth to botservice cli * minor fixes * fix style warnings * more pylint error fixes * fix flake errors * addressed comments. bumped up version * Static web and hierarchical namespace features. (#218) * updated sdk * service-properties update * initial generic update for blob service-properties * implemented generic update for service props * added testing and recording update * fixed bug * added test * recording * updated mgmt sdk for storage * added hierarchical namespace feature to account create * version bump * ci * pylint and re-recorded all tests * updated all recordings and tests for new sdks * IoT extension release 0.5.0 (#219) * IoT extension release 0.5.0 * fix dep format issue * change order of index dependencies * Index storage 0.1.3 (#220) * index storage * index edits * added examples and new features (#221) * updated api-version of arm to cli (#222) * updated api-version of arm to cli * converted all api-versions for resource * Update batch extension to 2.3.0 (#225) * changes to dependency check (#226) * changes to dependency check * CI * Fixed: can not connect when using slot option. (#227) * [0.8.0] Update SDK to Mesh namespace * Use new namespace * Run tests * iteration1 comments * new lines * Drop commands for legacy resources * Add license header * Comments * Delete sbz * Api version * fix history * Mesh preview rc (#29) * Remove rdbms public CLI extension. (#179) * Worm feature and listing usage by region (#181) * vendored mgmt sdk * sdk * updated old recordings for new sdk * added worm feature enable listing usage by region ci fixes fixes fixes flake8 fixes removed prints * address feedback * updated index with new extension path * version bump in index * Updating the dev-spaces command from aks group to ads group (#183) * Updating the dev-spaces command from aks group to ads group - refactoring * Installing cli tooling, if does not exist, on remove command * Updating min req of azure cli to 2.0.32 * Reverting index related changes - will send out a separate PR for this, after updating the generated whl file. * Updating index: sha and minCliVersion (#185) * iotext v0.4.5 (#188) * iotext v0.4.5 * Fix sha256 hash. * Bumping Dev Spaces version to 0.1.1 and updating the Index (#186) * VNET extension (#176) * VNET extension Adding VNET extension for public repo , Pending changes : update index.json to add the extension and uploading .whl file to blob repo will happen later . * fixing indentation fixing indentation * fixing more flake8 reported issues fixing more flake8 reported issues * Fixing Review comments and formatting issues. Fixing Review comments and formatting issues. * Fixing some more issues with source static and bug fixes Fixing some more issues with source static and bug fixes * Renaming _client_factory to _client_vnet_factory Renaming _client_factory to _client_vnet_factory * Reverting the last change Reverting the last change * Renaming to azext_rdbms_vnet Renaming to azext_rdbms_vnet * More formatting issue fix More formatting issue fix * adding code owners adding code owners * Adding my email id Adding my email id :) * Adding extension to index.json wheel file is already uploaded to prodrdbmsclipackages * fixing index-verify fixing index-verify * Changed the default value for eventdeliveryschema parameter to match the input event schema. (#189) * Added eventgrid preview extension to index.json. * Made the hash lowercase. * Regenerated using Wheel 0.30 * Updating index metadata to match with what's in the package. * Updated the description to match what's in the package. * Added minCliCoreVersion in index.json to match with the metadata in the package. * Changed the default value for eventdeliveryschema parameter to match the input event schema. * Updated version in index.json and fixed the default in the function argument list. * Changing SHA256digest to lower case. * Regenerated extension with 0.30.0 of wheel to resolve CI errors. * Updating space select functionality (#191) * Updating space select - selecting space on resource create/select both - updating azds osx url * Update * CR * Adding comments * CR * Management policy and new api-version (#194) * added new apiversion for mgmt sdk * updated storage mgmt client for new api * updated sdk and most recordings except show usage * finalized commands * usage to usages and help * fixed excryption tests * static check * updated help * Management policy recording and new version of wheel (#195) * updated some recordings * added new wheel to index * project url * updated whl * update index.json with new botservice package(minor fixes) (#199) * update index.json with new botservice package(minor fixes) * update version on index.json to match the new package * Updating dev-spaces-preview extension to honor azds commands update (#196) * Updating dev-spaces-preview extension to honor azds commands update * Adding update option to force install the newer version of azds tool * Update remove command * Index Update * Image-Copy: add support for sources backup by vhd files and snapshots (#201) * update descriptions and version * Add checks to verify that the source has a managed disk * fix procedure to name the temp storage account * support tags and final image name * fix lint issue * remove debug statement * add version 0.0.6 to index * support sources backed by vhd blobs (copied images) and snapshots * fix how we find the source_os_disk_id * adding image-copy version 0.0.7 to the index * fix issue with publishing to bot (#202) * fix missing client error during publish * update index.json * remove unused client variable * Updating some params of use command (#200) * Updating some params of use command * Updating index and bumping version * Removing commands and just keeping the module library to be accessed by azure cli * Index update * disable=too-few-public-methods * extend alotted time for script in travis (#208) * extend alotted time for script in travis * longer CI times for surcetests * Updates to extension documentation (#210) * doc for vendored_sdks folder * add README to point at extension docs in azure-cli folder * forgot to add docs readme * DMS - Adding PG and MySQL extension (#207) * Added functionality for Data Migration Assistant * Renamed extension * Updated the default database for PG * Updated the extension description to remove any CLI references * Renamed 'mgmt' to 'vendored_sdks' * Fixed pylint issues * extend alotted time for script in travis * Fixed flake8 test results * Updated code owners * Added metadata * Added license headers * added information to storage-preview extension readme for included features (#212) * Updating az use call to azds cli (#211) * Updating az use call to azds cli - addressing azds updated cli * Fix indentation error * update * Update * CR: renaming the prompt variable * readme changes (#214) * Updating output messages to be printed in default mode (#215) * Updating output messages to be printed in default mode * Code Review Update * increase travis wait time for source tests * Add support for oauth connection management in botservice (#213) * add support for oauth to botservice cli * minor fixes * fix style warnings * more pylint error fixes * fix flake errors * addressed comments. bumped up version * Static web and hierarchical namespace features. (#218) * updated sdk * service-properties update * initial generic update for blob service-properties * implemented generic update for service props * added testing and recording update * fixed bug * added test * recording * updated mgmt sdk for storage * added hierarchical namespace feature to account create * version bump * ci * pylint and re-recorded all tests * updated all recordings and tests for new sdks * IoT extension release 0.5.0 (#219) * IoT extension release 0.5.0 * fix dep format issue * change order of index dependencies * Index storage 0.1.3 (#220) * index storage * index edits * added examples and new features (#221) * updated api-version of arm to cli (#222) * updated api-version of arm to cli * converted all api-versions for resource * Update batch extension to 2.3.0 (#225) * changes to dependency check (#226) * changes to dependency check * CI * Fixed: can not connect when using slot option. (#227) * improved the deployment create command to now display back the public IP Addresses of the applications if available otherwise the status of the applications within the tempalte * added warning for when a network for an application can not be reached * added in displaying arm deployment errors * removed ~ folder * fixed the imports from client factory * removing files * specified errors and reduced clutter and depth of if statements * removed .vs * put in ascii friendly character * docs (#228) * added better logic handling for errors and show running now * fixed import for http error from network client * changed setup.py to 0.9.0 and changed the deploying to not redisplay * removed the untested parts * fixed white space comma issue * updated version * added history.rst version * improved wording of history.rst * added more safety checks for getting network references. reduced duplicate checks for looping over applications. fixed outputting for a few different places * Automationstatic (#232) * use flake8 config to apply exclusions, remove travis wait * pin pylint 1.9.2 for CI * fix link for extension summary for PRs (#233) * Checks for license presence while disregarding '#\n' (#237) * license ignore newlines * added licenses * cleanup * add static check as precheck (#238) * add static check as precheck * made basic index verification part of precheck * added network ref parse ability for other common format * started adding validation precheck to deploying * now has validation error check first * changed len check of string * cleaned up output * fixed formatting * fixed formatting of EOF lines * removed logging statement * removed the no wait from validation because it didnt seem necessary * ref doc gen broken due to deprecation work (#240) * should now just return expressions from the function and removed unused import * removed .idea files * should fix the inconsistent return formatting issue * added back missing new line * check_call will block child_process if enough output is sent to PIPE (#243) * check_call will block child_process if enough output is sent to PIPE * run is unavailable in python2, opting for check_output which reads from the PIPE * remove PIPE * fixed client naming * Add to index.json * Update module name * Update author name * Fix CI error * Fix CI
evelyn-ys
pushed a commit
that referenced
this pull request
Jan 31, 2023
* Kubernetes Data Protection Extension CLI (#173) * First draft for Data Protection K8s backup extension (Pending internal review) * Removing tracing * Minor changes to improve azdev style * Internal PR review feedback Co-authored-by: Rishabh Raj <[email protected]> * {AKS - ARC} fix: Update DCR creation to Clusters resource group instead of workspace (#175) * fix: Update DCR creation to Clusters resource group instead of workspace * . * . * casing check * Add self-signed cert to fix PR gate for azureml extension * adding the api version to the operation definition in the client factory * bump k8s-extension version to 1.3.6 * adding tests for all 4 extension types calls * adding to test config file * updating the api version for extension types to be the correct version expected by the service * add test case for flux extension (#184) * bump k8s-extension version to 1.3.6 * bump k8s-extension version to 1.3.6 * adding upstream test for extension types * updating history.rst * [Dapr] Prompt user for existing Dapr installation during extension create (#188) * Add more validations and user prompt for existing installation scenario Signed-off-by: Shubham Sharma <[email protected]> * Add Dapr test' Signed-off-by: Shubham Sharma <[email protected]> * Handle stateful set Signed-off-by: Shubham Sharma <[email protected]> * Update default handling Signed-off-by: Shubham Sharma <[email protected]> * Fix HA handling Signed-off-by: Shubham Sharma <[email protected]> * Add placement service todo Signed-off-by: Shubham Sharma <[email protected]> * Add non-interactive mode Signed-off-by: Shubham Sharma <[email protected]> * Fix lint Signed-off-by: Shubham Sharma <[email protected]> * Update tests Signed-off-by: Shubham Sharma <[email protected]> * Reset configuration for StatefulSet during k8s upgrade Signed-off-by: Shubham Sharma <[email protected]> * Fix lint Signed-off-by: Shubham Sharma <[email protected]> * Retrigger tests Signed-off-by: Shubham Sharma <[email protected]> * Add changes to manage ha and placement params Signed-off-by: Shubham Sharma <[email protected]> * Update message Signed-off-by: Shubham Sharma <[email protected]> * nits Signed-off-by: Shubham Sharma <[email protected]> Signed-off-by: Shubham Sharma <[email protected]> * bump k8s-extension version to 1.3.7 * [Dapr] Disable applying CRDs during a downgrade (#193) * Add logging Signed-off-by: Shubham Sharma <[email protected]> * Lint Signed-off-by: Shubham Sharma <[email protected]> * Update log Signed-off-by: Shubham Sharma <[email protected]> * Revert applyCrds when not downgrading Signed-off-by: Shubham Sharma <[email protected]> * Update logic for removing hooks.applyCrds Signed-off-by: Shubham Sharma <[email protected]> * Revert logic Signed-off-by: Shubham Sharma <[email protected]> * Handle explicit hooks configuration Signed-off-by: Shubham Sharma <[email protected]> * Update comment Signed-off-by: Shubham Sharma <[email protected]> * re-trigger pipeline Signed-off-by: Shubham Sharma <[email protected]> Signed-off-by: Shubham Sharma <[email protected]> * ContainerInsights extension - Add dataCollectionSettings configuration settings (#200) * data collection settings * add support for dataCollectionSettings * fix indention * avoid duplicate use of json loads * remove whitespaces * fix pr feedback * Upgrade Python version from 3.6 to 3.7 (#203) * Upgrade Python version from 3.6 to 3.10 Upgrade to 3.10 for the job that runs Wheel, PyLint, Flake, etc., since 3.6 is not supported anymore by hosted-agent-software. * Upgrade to Python 3.10 from 3.6 Upgrade to 3.10 as 3.6 is not supported * Switch PyLink to 1.9.4 Switch PyLink to 1.9.4 from 1.9.5, as 1.9.5 is not supported with Python 3.10 * Use Python 3.7 for Static Analysis Use 3.7, as 3.10 does not support certain properties used by astpeephole.py that is used by Static Analysis tools * Try unpinned version of PyLint PyLint 1.9.5 doesn't work with Python 3.7. So, trying to see if it automatically pulls the latest compatible version. * Run pylint as a separate command * Update pylintrc (#204) * Update pylintrc * Update k8s-custom-pipelines.yml * Disable PyLint (#205) Disable PyLint for now, as the new version has breaking changes and requires lot more fixes * Disable PyLint on CI scripts * Fixes for script errors * Upgrade Static Analysis Python version Upgrade the Python version for Static Analysis to 3.10, from 3.7, now that PyLint is disabled * Try 3.9, as 3.10 has breaking changes for Flake8 * Remove version pinning for flake8 Try Python 3.10, without pinning flake8 to a version * Update k8s-custom-pipelines.yml * Use Python 3.8.1 & flake8 6.0.0 * Use Python 3.8 instead of 3.8.1 * Update k8s-custom-pipelines.yml * Update .flake8 Update to reflect breaking change in flake8 6.0 * Update source_code_static_analysis.py Scope static analysis tools to only k8s-extension module's source in our branch. * Update k8s-custom-pipelines.yml * Update k8s-custom-pipelines.yml * Update k8s-custom-pipelines.yml * Update pool name in StaticAnalysis To mirror what is in main of azure-cli-extensions * Update k8s-custom-pipelines.yml * Fix indentation * Update k8s-custom-pipelines.yml * Update k8s-custom-pipelines.yml * Revert changes * Revert changes * Revert changes to source_code_static_analysis.py * Update source_code_static_analysis.py * Revert changes * Use Ubuntu 20.4 for BuiltTestPublish stage * Switch to ubuntu-20.04 from latest Co-authored-by: Rishik Hombal <[email protected]> * [Dapr] Do not apply CRD hook when version is unchanged or auto-upgrade is being disabled (#201) * Update logic Signed-off-by: Shubham Sharma <[email protected]> * re-trigger pipeline Signed-off-by: Shubham Sharma <[email protected]> * re-trigger pipeline Signed-off-by: Shubham Sharma <[email protected]> Signed-off-by: Shubham Sharma <[email protected]> Co-authored-by: NarayanThiru <[email protected]> * add dummy key for amalogs as well * bump k8s-extension version to 1.3.8 * Adding GA api version 2022-11-01 exposing isSystemExtension and support for plan info * Seperate args for plan name, product and publisher * updating cassete file * updating HISTORY.rst * Deprecate longer parameter names when accepting config settings (#213) Co-authored-by: deeksha345 <[email protected]> * Release 1.3.9 * [k8s-extension] Update extension CLI to v1.3.9 --------- Signed-off-by: Shubham Sharma <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: bragi92 <[email protected]> Co-authored-by: Yue Yu <[email protected]> Co-authored-by: Deeksha Sharma <[email protected]> Co-authored-by: deeksha345 <[email protected]> Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Shubham Sharma <[email protected]> Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Ganga Mahesh Siddem <[email protected]> Co-authored-by: NarayanThiru <[email protected]> Co-authored-by: Rishik Hombal <[email protected]> Co-authored-by: Amol Agrawal <[email protected]> Co-authored-by: Amol Agrawal <[email protected]> Co-authored-by: Arif Lakhani <[email protected]>
ms-hujia
pushed a commit
to ms-hujia/azure-cli-extensions
that referenced
this pull request
Jun 21, 2023
…e#213) Co-authored-by: deeksha345 <[email protected]>
wangzelin007
pushed a commit
that referenced
this pull request
Sep 4, 2023
* Kubernetes Data Protection Extension CLI (#173) * First draft for Data Protection K8s backup extension (Pending internal review) * Removing tracing * Minor changes to improve azdev style * Internal PR review feedback Co-authored-by: Rishabh Raj <[email protected]> * {AKS - ARC} fix: Update DCR creation to Clusters resource group instead of workspace (#175) * fix: Update DCR creation to Clusters resource group instead of workspace * . * . * casing check * Add self-signed cert to fix PR gate for azureml extension * adding the api version to the operation definition in the client factory * bump k8s-extension version to 1.3.6 * adding tests for all 4 extension types calls * adding to test config file * updating the api version for extension types to be the correct version expected by the service * add test case for flux extension (#184) * bump k8s-extension version to 1.3.6 * bump k8s-extension version to 1.3.6 * adding upstream test for extension types * updating history.rst * [Dapr] Prompt user for existing Dapr installation during extension create (#188) * Add more validations and user prompt for existing installation scenario Signed-off-by: Shubham Sharma <[email protected]> * Add Dapr test' Signed-off-by: Shubham Sharma <[email protected]> * Handle stateful set Signed-off-by: Shubham Sharma <[email protected]> * Update default handling Signed-off-by: Shubham Sharma <[email protected]> * Fix HA handling Signed-off-by: Shubham Sharma <[email protected]> * Add placement service todo Signed-off-by: Shubham Sharma <[email protected]> * Add non-interactive mode Signed-off-by: Shubham Sharma <[email protected]> * Fix lint Signed-off-by: Shubham Sharma <[email protected]> * Update tests Signed-off-by: Shubham Sharma <[email protected]> * Reset configuration for StatefulSet during k8s upgrade Signed-off-by: Shubham Sharma <[email protected]> * Fix lint Signed-off-by: Shubham Sharma <[email protected]> * Retrigger tests Signed-off-by: Shubham Sharma <[email protected]> * Add changes to manage ha and placement params Signed-off-by: Shubham Sharma <[email protected]> * Update message Signed-off-by: Shubham Sharma <[email protected]> * nits Signed-off-by: Shubham Sharma <[email protected]> Signed-off-by: Shubham Sharma <[email protected]> * bump k8s-extension version to 1.3.7 * [Dapr] Disable applying CRDs during a downgrade (#193) * Add logging Signed-off-by: Shubham Sharma <[email protected]> * Lint Signed-off-by: Shubham Sharma <[email protected]> * Update log Signed-off-by: Shubham Sharma <[email protected]> * Revert applyCrds when not downgrading Signed-off-by: Shubham Sharma <[email protected]> * Update logic for removing hooks.applyCrds Signed-off-by: Shubham Sharma <[email protected]> * Revert logic Signed-off-by: Shubham Sharma <[email protected]> * Handle explicit hooks configuration Signed-off-by: Shubham Sharma <[email protected]> * Update comment Signed-off-by: Shubham Sharma <[email protected]> * re-trigger pipeline Signed-off-by: Shubham Sharma <[email protected]> Signed-off-by: Shubham Sharma <[email protected]> * ContainerInsights extension - Add dataCollectionSettings configuration settings (#200) * data collection settings * add support for dataCollectionSettings * fix indention * avoid duplicate use of json loads * remove whitespaces * fix pr feedback * Upgrade Python version from 3.6 to 3.7 (#203) * Upgrade Python version from 3.6 to 3.10 Upgrade to 3.10 for the job that runs Wheel, PyLint, Flake, etc., since 3.6 is not supported anymore by hosted-agent-software. * Upgrade to Python 3.10 from 3.6 Upgrade to 3.10 as 3.6 is not supported * Switch PyLink to 1.9.4 Switch PyLink to 1.9.4 from 1.9.5, as 1.9.5 is not supported with Python 3.10 * Use Python 3.7 for Static Analysis Use 3.7, as 3.10 does not support certain properties used by astpeephole.py that is used by Static Analysis tools * Try unpinned version of PyLint PyLint 1.9.5 doesn't work with Python 3.7. So, trying to see if it automatically pulls the latest compatible version. * Run pylint as a separate command * Update pylintrc (#204) * Update pylintrc * Update k8s-custom-pipelines.yml * Disable PyLint (#205) Disable PyLint for now, as the new version has breaking changes and requires lot more fixes * Disable PyLint on CI scripts * Fixes for script errors * Upgrade Static Analysis Python version Upgrade the Python version for Static Analysis to 3.10, from 3.7, now that PyLint is disabled * Try 3.9, as 3.10 has breaking changes for Flake8 * Remove version pinning for flake8 Try Python 3.10, without pinning flake8 to a version * Update k8s-custom-pipelines.yml * Use Python 3.8.1 & flake8 6.0.0 * Use Python 3.8 instead of 3.8.1 * Update k8s-custom-pipelines.yml * Update .flake8 Update to reflect breaking change in flake8 6.0 * Update source_code_static_analysis.py Scope static analysis tools to only k8s-extension module's source in our branch. * Update k8s-custom-pipelines.yml * Update k8s-custom-pipelines.yml * Update k8s-custom-pipelines.yml * Update pool name in StaticAnalysis To mirror what is in main of azure-cli-extensions * Update k8s-custom-pipelines.yml * Fix indentation * Update k8s-custom-pipelines.yml * Update k8s-custom-pipelines.yml * Revert changes * Revert changes * Revert changes to source_code_static_analysis.py * Update source_code_static_analysis.py * Revert changes * Use Ubuntu 20.4 for BuiltTestPublish stage * Switch to ubuntu-20.04 from latest Co-authored-by: Rishik Hombal <[email protected]> * [Dapr] Do not apply CRD hook when version is unchanged or auto-upgrade is being disabled (#201) * Update logic Signed-off-by: Shubham Sharma <[email protected]> * re-trigger pipeline Signed-off-by: Shubham Sharma <[email protected]> * re-trigger pipeline Signed-off-by: Shubham Sharma <[email protected]> Signed-off-by: Shubham Sharma <[email protected]> Co-authored-by: NarayanThiru <[email protected]> * add dummy key for amalogs as well * bump k8s-extension version to 1.3.8 * Adding GA api version 2022-11-01 exposing isSystemExtension and support for plan info * Seperate args for plan name, product and publisher * updating cassete file * updating HISTORY.rst * Deprecate longer parameter names when accepting config settings (#213) Co-authored-by: deeksha345 <[email protected]> * Release 1.3.9 * make containerinsights dcr name consistent (#211) Co-authored-by: Bavneet Singh <[email protected]> * [Dapr] Update version comparison logic to use semver based comparison (#219) * Update semver comparison Signed-off-by: Shubham Sharma <[email protected]> * Add log Signed-off-by: Shubham Sharma <[email protected]> --------- Signed-off-by: Shubham Sharma <[email protected]> * bump k8s-extension version to 1.4.0 (#220) * Revert "bump k8s-extension version to 1.4.0 (#220)" (#222) This reverts commit ffb8a95. * [k8s-extension] Update extension CLI to v1.4.0 * update release history * fix openservice mesh cli testcase issue * Zetia/fix ssl secret flag (#224) * fix bug: update operation doesn't respect sslSecret parameter * fix bug: update operation doesn't respect sslSecret parameter * fix typo * feat: public preview support for microsoft.azuremonitor.containers.metrics in ARC clusters (managed prometheus) (#227) * remove redundant extension test (#230) * ci MSI default for arc cluster (#231) * bump k8s-extension version to 1.4.2 * ContainerInsights extension - Extend dataCollectionSettings config settings with streams field (#232) * extend containerinsights datacollection settings with streams field * bug fix * fix lint issues * fix pr feedback * fix pr feedback * fix lint error * Generated files for 2023-05-01-preview * Support for 2023-05-01-preview * Rename get to show * Added ExtensionType api test cases * ContainerInsights extension - Extend dataCollectionSettings with containerlogv2 (#237) * Fix for Liniting issues * Fixing test cases * comment failing test cases * [k8s-extension] add kind tag in DCR creation (#240) * Use semver package (#241) Signed-off-by: Shubham Sharma <[email protected]> * Reverting commented test cases * Add support to skip provisioning of prerequisites for Azure Monitor K8s extensions (#234) * {ARC} fix: update logic to sanitize cluster name for dc* objects (#242) * Fix osm-arc version check for CI tags (#244) Signed-off-by: nshankar <[email protected]> Co-authored-by: nshankar <[email protected]> * New cassette file * Remove unused propeties from table format * bump k8s-extension version 1.4.3 * Add old commands back with deprecated status * Fix linting issues * Reverting changes for extensions type api * change the location for test runs and arc clusters * [k8s-extension] create new cli release - v1.4.3 (#250) * Revert "[k8s-extension] create new cli release - v1.4.3 (#250)" (#251) This reverts commit 584815d. * [k8s-extension] Update extension CLI to v1.4.3 * Drop relay sdk (#254) * update readme * remove useless snippets (#256) * [k8s-extension] Update extension CLI to v1.4.4 --------- Signed-off-by: Shubham Sharma <[email protected]> Signed-off-by: nshankar <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: bragi92 <[email protected]> Co-authored-by: Yue Yu <[email protected]> Co-authored-by: Deeksha Sharma <[email protected]> Co-authored-by: deeksha345 <[email protected]> Co-authored-by: Shubham Sharma <[email protected]> Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Ganga Mahesh Siddem <[email protected]> Co-authored-by: NarayanThiru <[email protected]> Co-authored-by: Rishik Hombal <[email protected]> Co-authored-by: Amol Agrawal <[email protected]> Co-authored-by: Amol Agrawal <[email protected]> Co-authored-by: Arif Lakhani <[email protected]> Co-authored-by: Arif-lakhani <[email protected]> Co-authored-by: Zeliang Tian <[email protected]> Co-authored-by: Long Wan <[email protected]> Co-authored-by: ms-hujia <[email protected]> Co-authored-by: Niranjan Shankar <[email protected]> Co-authored-by: nshankar <[email protected]> Co-authored-by: necusjz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am just checking in the feature work for now. i will publish a new extension around next week, when the associated deployment completes.