Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylint enabled for all extensions, errors cleaned up for all extensions #177

Merged
merged 5 commits into from
May 11, 2018
Merged

Pylint enabled for all extensions, errors cleaned up for all extensions #177

merged 5 commits into from
May 11, 2018

Conversation

williexu
Copy link
Contributor

@williexu williexu commented May 11, 2018 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run ./scripts/ci/test_static.sh locally? (pip install pylint flake8 required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

williexu and others added 5 commits May 9, 2018 15:36
@williexu
fixed some pylint errors
e81cea7
@williexu
fixed some webapp pylint violations
7d6f801
@swagatmishra2007 @williexu
correct pylint errors in botservice (#171)
7ce8a34 
* correct pylint errors in botservice

* fix a couple more pylint errors in botservice
@williexu
Fixes for python 2 env (#174)
66f3755 
* Fixes for python 2 env

* disabled too few methods for ChannelOperations class
@panchagnula @williexu
Pylint fixes for webapp extension (#175)
fe91b65 
* Plylint fixes for Webapp

* Pylint fixes

* More Pylint fixes

* addressing PR feedback
@williexu williexu requested a review from panchagnula as a code owner May 11, 2018 00:14
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/Azure/azure-cli-extensions.git@pylint#subdirectory=src/$EXT&egg=$EXT"

@williexu williexu merged commit 8241b5d into master May 11, 2018
@williexu williexu deleted the pylint branch May 11, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panchagnula panchagnula Awaiting requested review from panchagnula

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@williexu @azuresdkci @swagatmishra2007 @panchagnula