Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes connect cli telemetry integration #1684

Merged
merged 70 commits into from
May 13, 2020

Conversation

akashkeshari
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

Akash Keshari and others added 30 commits November 12, 2019 12:59
@akashkeshari akashkeshari changed the title Akash/connect telemetry Kubernetes connect cli telemetry integration May 12, 2020
@yonzhan yonzhan requested review from fengzhou-msft and qwordy May 12, 2020 10:43
@yonzhan yonzhan added this to the S169 milestone May 12, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented May 12, 2020

add to S169

@yungezz yungezz assigned fengzhou-msft and unassigned yungezz May 12, 2020
@yungezz yungezz removed this from the S169 milestone May 12, 2020
@fengzhou-msft
Copy link
Member

Please add change log in HISTORY.rst.

Please also test locally and check the telemetry log in ~/.azure/telemetry/cache to see if the properties are expected.

@akashkeshari
Copy link
Contributor Author

Please add change log in HISTORY.rst.

Please also test locally and check the telemetry log in ~/.azure/telemetry/cache to see if the properties are expected.

I have updated the History.rst file. I have also verified in telemetry local cache that all expected properties are being stored

@fengzhou-msft fengzhou-msft merged commit db1f4bd into Azure:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants