Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rg and query modes add new option: --include-role-assignment & query mode add new option --include-resource-group #468

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Nov 1, 2023

This PR updates the dependency on azlist (magodo/azlist@835b23b), where it adds support to list extension resources, and also include the resource groups that the listed resources belong to.

Based on that, we now introduced the following new options:

  • --include-resource-group: This applies to the query mode, so that we can also export the resources together with their containing resource groups.
  • --include-role-assignment: This applies to the query mode and resource-group mode. This option will export the role assignments directly assigned to any of the resources being exported. This means we won't export any of the inherited role assignments.

Fix #446

…`query` mode add new option `--include-resource-group`
@magodo magodo added the enhancement New feature or request label Nov 1, 2023
@magodo magodo requested review from ms-henglu and stemaMSFT November 1, 2023 02:41
Copy link
Member

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@stemaMSFT stemaMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can't seem to get my git checkout working, so may play with the PR once merged.

@magodo magodo merged commit c6e0cf1 into Azure:main Nov 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Role Assignments
3 participants