Do once empty check on the outdir prior to TF run #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TF run with `TF_LOG_PATH` set to a local file will cause the empty check on the output dir return non-empty on the second check in the `Init()` (actually `initProvider()`) function. In this case, the existing logic will work in append mode, especially it creates the `provider.tf` with no `terraform` setting, i.e. no provider setting. This results into inconsistent dependency lock issues when users are not opt in the `dev_overrides`. Meanwhile, this commit explicitly set the `TF_LOG` and `TF_LOG_PATH` from the environment, for the terraform-exec library. So that users can inspect what is going on via Terraform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TF run with
TF_LOG_PATHset to a local file will cause the empty check on the output dir return non-empty on the second check in theInit()(actuallyinitProvider()) function. In this case, the existing logic will work in append mode, especially it creates theprovider.tfwith noterraformsetting, i.e. no provider setting. This results intoinconsistent dependency lock issues when users are not opt in the
dev_overrides.Meanwhile, this commit explicitly set the
TF_LOGandTF_LOG_PATHfrom the environment, for the terraform-exec library. So that users can inspect what is going on via Terraform.The demo of the original issue is as below: