Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize resource id for signalr service #155

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jun 21, 2022

Fix #154

Test

💤  AZTFY_E2E=1 go test -timeout=30m -v -run=TestSignalRService ./internal/test
=== RUN   TestSignalRService
=== PAUSE TestSignalRService
=== CONT  TestSignalRService
Initializing...
List resources...
Import resources...
Importing /subscriptions/67a9759d-d099-4aa8-8675-e6cfd669c3f4/resourceGroups/aztfy-rg-oyllyuvm/providers/Microsoft.SignalRService/signalR/test-oyllyuvm as azurerm_signalr_service.test
Importing /subscriptions/67a9759d-d099-4aa8-8675-e6cfd669c3f4/resourceGroups/aztfy-rg-oyllyuvm as azurerm_resource_group.test
Generating Terraform configurations...
--- PASS: TestSignalRService (237.15s)
PASS
ok      github.com/Azure/aztfy/internal/test    237.286s

Copy link
Member

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@magodo magodo merged commit 1b0effe into Azure:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AzureRM SignalR resource ID is case sensitive
2 participants