Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add azure analysis service scanner #221

Merged
merged 6 commits into from
Apr 25, 2024
Merged

feature: add azure analysis service scanner #221

merged 6 commits into from
Apr 25, 2024

Conversation

vanwinkelseppe
Copy link
Contributor

Description

Add a Analytics Service scanner with the following rules:

  • Diagnostic settings
  • SLA
  • Tags
  • CAF Naming conventions

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #220

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • Linting
  • [] Ran documentation script

@vanwinkelseppe
Copy link
Contributor Author

have to update the rule documentation but waiting till end to reduce amount of commits to update for every PR/rebase

cmendible
cmendible requested changes Apr 24, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
cmd/azqr/as.go Outdated Show resolved Hide resolved
cmd/azqr/as.go Outdated Show resolved Hide resolved
docs/content/en/docs/Overview/_index.md Outdated Show resolved Hide resolved
internal/scanners/as/rules.go Outdated Show resolved Hide resolved
cmendible
cmendible requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one! We are almost there!

internal/scanners/as/rules.go Outdated Show resolved Hide resolved
internal/scanners/as/rules.go Outdated Show resolved Hide resolved
@vanwinkelseppe
Copy link
Contributor Author

Thanks for this one! We are almost there!

@cmendible all done, waiting to run docs until it's looking good

cmendible
cmendible requested changes Apr 25, 2024
View reviewed changes
internal/scanners/as/as.go Outdated Show resolved Hide resolved
cmendible
cmendible approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmendible cmendible changed the title feature: add azure analytics service scanner feature: add azure analysis service scanner Apr 25, 2024
cmendible
cmendible requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new scanner must be added to the GetScanners() func.

cmendible
cmendible approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmendible cmendible merged commit 4b5718a into Azure:main Apr 25, 2024
12 checks passed
@vanwinkelseppe vanwinkelseppe deleted the feature/as branch April 25, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmendible cmendible cmendible approved these changes

Assignees

@vanwinkelseppe vanwinkelseppe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Azure Analysis Service Scanner
2 participants
@vanwinkelseppe @cmendible