-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All Stream request body APIs should use Transfer-Encoding:chunked #903
Comments
begoldsm
pushed a commit
to begoldsm/azure-rest-api-specs
that referenced
this issue
Apr 8, 2016
explicitly calling out our chunked transfer APIs until issue: Azure/autorest#903 is resolved.
amarzavery
pushed a commit
to Azure/azure-rest-api-specs
that referenced
this issue
Apr 20, 2016
* Remove requirement on subscriptionId These clients don't need a subscriptionId. * Need to make contents required since this is a PUT. Will add extensions that make it optional in C# and zero it out to an empty stream. * update documentation to reflect param required * undo this temp change Issue: Azure/autorest#884 is tracking support for this being an optional param properly and not resulting in a null reference. So I will keep this spec as is. * Change this name to be more descriptive. * does not need to be modeled as a string. Makes this more obvious to end users and easier to understand. * fix all enums to be enums. * Add new API version for job This API version changes the format for dates and timespan objects to be ISO compliant. * missed version change here as well. * temp commit to remove the required flag We need a way to have template parameters not be required when they are in the host. I will work with Amar for this next week. * Revert "temp commit to remove the required flag" This reverts commit be8b7bf. * Add missing enum value * Missed one. * Add in new functionality Switch over to MSLISTSTATUS which gives more flexibility for listing files/folders. * Work around for issue: 903 explicitly calling out our chunked transfer APIs until issue: Azure/autorest#903 is resolved. * addressed comments from Amar.
amarzavery
pushed a commit
to Azure/azure-rest-api-specs
that referenced
this issue
May 24, 2016
* Remove requirement on subscriptionId These clients don't need a subscriptionId. * Need to make contents required since this is a PUT. Will add extensions that make it optional in C# and zero it out to an empty stream. * update documentation to reflect param required * undo this temp change Issue: Azure/autorest#884 is tracking support for this being an optional param properly and not resulting in a null reference. So I will keep this spec as is. * Change this name to be more descriptive. * does not need to be modeled as a string. Makes this more obvious to end users and easier to understand. * fix all enums to be enums. * Add new API version for job This API version changes the format for dates and timespan objects to be ISO compliant. * missed version change here as well. * temp commit to remove the required flag We need a way to have template parameters not be required when they are in the host. I will work with Amar for this next week. * Revert "temp commit to remove the required flag" This reverts commit be8b7bf. * Add missing enum value * Missed one. * Add in new functionality Switch over to MSLISTSTATUS which gives more flexibility for listing files/folders. * Work around for issue: 903 explicitly calling out our chunked transfer APIs until issue: Azure/autorest#903 is resolved. * addressed comments from Amar. * fix descriptions and add partition APIs * Add missing method to delete all secrets in db In hyak, we could do this by simply excluding the parameter. That is not swagger compliant, so we need a separate entry. * temporarily remove partition list for current ship. this will be in the next snap. * Add diagnostics to USqlJobProperties. This was missing during the port from Hyak. * Missing enum value. * two more missing enums. * Put partitions back in for next release. * Test out composites. * add the log folder and logFilePattern to the sdk This is for all jobs going forward. Fix the readOnly properties to be bool instead of strings (makes tests happy). * Remove composite specs since they don't work * Error json fixes InnerError fixed to innerError Adding the WebHDFS definition for ErrorResponses to the filesystem. * bad syntax is bad. * missed a boolean switch for readOnly,. * definition -> definitions * Change the name to be more descriptive * Following feedback from the slack forum This should help reduce the levels of nesting and also fixes some feedback in the job swagger. * Add discriminators for webhdfs * Further flatten and rename Removing WebHdfsError and renaming "RemoteException" * Rename to Adls * nested exception discriminator * update the required piece. * try not indexing * move it down to see if this fixes it. * Try nesting again. * Trying a work around. Add a placeholder property at the root level which should get properly picked up. * Update to the work around Slight change to the stub property. * Work around didn't work, going back to what did. * Removed the unneccessary nesting. * Add the accesscontrolexception * remove extra next link stuff I thought I had removed this previously. removing it again, since it should no longer be used. * Remove currently unsupported API
amarzavery
pushed a commit
to Azure/azure-rest-api-specs
that referenced
this issue
May 24, 2016
* Remove requirement on subscriptionId These clients don't need a subscriptionId. * Need to make contents required since this is a PUT. Will add extensions that make it optional in C# and zero it out to an empty stream. * update documentation to reflect param required * undo this temp change Issue: Azure/autorest#884 is tracking support for this being an optional param properly and not resulting in a null reference. So I will keep this spec as is. * Change this name to be more descriptive. * does not need to be modeled as a string. Makes this more obvious to end users and easier to understand. * fix all enums to be enums. * Add new API version for job This API version changes the format for dates and timespan objects to be ISO compliant. * missed version change here as well. * temp commit to remove the required flag We need a way to have template parameters not be required when they are in the host. I will work with Amar for this next week. * Revert "temp commit to remove the required flag" This reverts commit be8b7bf. * Add missing enum value * Missed one. * Add in new functionality Switch over to MSLISTSTATUS which gives more flexibility for listing files/folders. * Work around for issue: 903 explicitly calling out our chunked transfer APIs until issue: Azure/autorest#903 is resolved. * addressed comments from Amar. * fix descriptions and add partition APIs * Add missing method to delete all secrets in db In hyak, we could do this by simply excluding the parameter. That is not swagger compliant, so we need a separate entry. * temporarily remove partition list for current ship. this will be in the next snap. * Add diagnostics to USqlJobProperties. This was missing during the port from Hyak. * Missing enum value. * two more missing enums. * Put partitions back in for next release. * Test out composites. * add the log folder and logFilePattern to the sdk This is for all jobs going forward. Fix the readOnly properties to be bool instead of strings (makes tests happy). * Remove composite specs since they don't work * Error json fixes InnerError fixed to innerError Adding the WebHDFS definition for ErrorResponses to the filesystem. * bad syntax is bad. * missed a boolean switch for readOnly,. * definition -> definitions * Change the name to be more descriptive * Following feedback from the slack forum This should help reduce the levels of nesting and also fixes some feedback in the job swagger. * Add discriminators for webhdfs * Further flatten and rename Removing WebHdfsError and renaming "RemoteException" * Rename to Adls * nested exception discriminator * update the required piece. * try not indexing * move it down to see if this fixes it. * Try nesting again. * Trying a work around. Add a placeholder property at the root level which should get properly picked up. * Update to the work around Slight change to the stub property. * Work around didn't work, going back to what did. * Removed the unneccessary nesting. * Add the accesscontrolexception * remove extra next link stuff I thought I had removed this previously. removing it again, since it should no longer be used. * Remove currently unsupported API * Adding missing x-ms-odata tags in catalog
amarzavery
pushed a commit
to Azure/azure-rest-api-specs
that referenced
this issue
Jun 10, 2016
* Remove requirement on subscriptionId These clients don't need a subscriptionId. * Need to make contents required since this is a PUT. Will add extensions that make it optional in C# and zero it out to an empty stream. * update documentation to reflect param required * undo this temp change Issue: Azure/autorest#884 is tracking support for this being an optional param properly and not resulting in a null reference. So I will keep this spec as is. * Change this name to be more descriptive. * does not need to be modeled as a string. Makes this more obvious to end users and easier to understand. * fix all enums to be enums. * Add new API version for job This API version changes the format for dates and timespan objects to be ISO compliant. * missed version change here as well. * temp commit to remove the required flag We need a way to have template parameters not be required when they are in the host. I will work with Amar for this next week. * Revert "temp commit to remove the required flag" This reverts commit be8b7bf. * Add missing enum value * Missed one. * Add in new functionality Switch over to MSLISTSTATUS which gives more flexibility for listing files/folders. * Work around for issue: 903 explicitly calling out our chunked transfer APIs until issue: Azure/autorest#903 is resolved. * addressed comments from Amar. * fix descriptions and add partition APIs * Add missing method to delete all secrets in db In hyak, we could do this by simply excluding the parameter. That is not swagger compliant, so we need a separate entry. * temporarily remove partition list for current ship. this will be in the next snap. * Add diagnostics to USqlJobProperties. This was missing during the port from Hyak. * Missing enum value. * two more missing enums. * Put partitions back in for next release. * Test out composites. * add the log folder and logFilePattern to the sdk This is for all jobs going forward. Fix the readOnly properties to be bool instead of strings (makes tests happy). * Remove composite specs since they don't work * Error json fixes InnerError fixed to innerError Adding the WebHDFS definition for ErrorResponses to the filesystem. * bad syntax is bad. * missed a boolean switch for readOnly,. * definition -> definitions * Change the name to be more descriptive * Following feedback from the slack forum This should help reduce the levels of nesting and also fixes some feedback in the job swagger. * Add discriminators for webhdfs * Further flatten and rename Removing WebHdfsError and renaming "RemoteException" * Rename to Adls * nested exception discriminator * update the required piece. * try not indexing * move it down to see if this fixes it. * Try nesting again. * Trying a work around. Add a placeholder property at the root level which should get properly picked up. * Update to the work around Slight change to the stub property. * Work around didn't work, going back to what did. * Removed the unneccessary nesting. * Add the accesscontrolexception * remove extra next link stuff I thought I had removed this previously. removing it again, since it should no longer be used. * Remove currently unsupported API * Adding missing x-ms-odata tags in catalog * switch to GET for this call per the FE team This API supports both a GET and a POST, with the POST planning on being deprecated before we GA, so we are switching the SDK now in preparation. * Add partition properties parentName createDate * missed the # * Removing get/set from descriptions latest generation tool automatically adds it. * Fixed to not remove "Gets " from method descript * Add the get back to globals.
Howdy! In our planning for driving towards a stable '1.0' release, I'm marking this issue as 'deferred' 💤 and we're going to review it during the post-1.0 planning cycle. It's not to say that we're not going to work on it, or that this isn't not important, but at the moment, we're picking and choosing the stuff we must do before 1.0. 🏇 🏇 🏇 We'll make sure we pick this back up at that point. 🎉 |
amarzavery
pushed a commit
to Azure/azure-rest-api-specs
that referenced
this issue
Jun 16, 2016
* Remove requirement on subscriptionId These clients don't need a subscriptionId. * Need to make contents required since this is a PUT. Will add extensions that make it optional in C# and zero it out to an empty stream. * update documentation to reflect param required * undo this temp change Issue: Azure/autorest#884 is tracking support for this being an optional param properly and not resulting in a null reference. So I will keep this spec as is. * Change this name to be more descriptive. * does not need to be modeled as a string. Makes this more obvious to end users and easier to understand. * fix all enums to be enums. * Add new API version for job This API version changes the format for dates and timespan objects to be ISO compliant. * missed version change here as well. * temp commit to remove the required flag We need a way to have template parameters not be required when they are in the host. I will work with Amar for this next week. * Revert "temp commit to remove the required flag" This reverts commit be8b7bf. * Add missing enum value * Missed one. * Add in new functionality Switch over to MSLISTSTATUS which gives more flexibility for listing files/folders. * Work around for issue: 903 explicitly calling out our chunked transfer APIs until issue: Azure/autorest#903 is resolved. * addressed comments from Amar. * fix descriptions and add partition APIs * Add missing method to delete all secrets in db In hyak, we could do this by simply excluding the parameter. That is not swagger compliant, so we need a separate entry. * temporarily remove partition list for current ship. this will be in the next snap. * Add diagnostics to USqlJobProperties. This was missing during the port from Hyak. * Missing enum value. * two more missing enums. * Put partitions back in for next release. * Test out composites. * add the log folder and logFilePattern to the sdk This is for all jobs going forward. Fix the readOnly properties to be bool instead of strings (makes tests happy). * Remove composite specs since they don't work * Error json fixes InnerError fixed to innerError Adding the WebHDFS definition for ErrorResponses to the filesystem. * bad syntax is bad. * missed a boolean switch for readOnly,. * definition -> definitions * Change the name to be more descriptive * Following feedback from the slack forum This should help reduce the levels of nesting and also fixes some feedback in the job swagger. * Add discriminators for webhdfs * Further flatten and rename Removing WebHdfsError and renaming "RemoteException" * Rename to Adls * nested exception discriminator * update the required piece. * try not indexing * move it down to see if this fixes it. * Try nesting again. * Trying a work around. Add a placeholder property at the root level which should get properly picked up. * Update to the work around Slight change to the stub property. * Work around didn't work, going back to what did. * Removed the unneccessary nesting. * Add the accesscontrolexception * remove extra next link stuff I thought I had removed this previously. removing it again, since it should no longer be used. * Remove currently unsupported API * Adding missing x-ms-odata tags in catalog * switch to GET for this call per the FE team This API supports both a GET and a POST, with the POST planning on being deprecated before we GA, so we are switching the SDK now in preparation. * Add partition properties parentName createDate * missed the # * Removing get/set from descriptions latest generation tool automatically adds it. * Fixed to not remove "Gets " from method descript * Add the get back to globals. * Catalog item updates Add distributionInfo to tables Add a new type called USqlTableType * Fix URL based on feedback should be tabletypes instead of tables
begoldsm
pushed a commit
to begoldsm/azure-rest-api-specs
that referenced
this issue
Jul 11, 2016
explicitly calling out our chunked transfer APIs until issue: Azure/autorest#903 is resolved.
fearthecowboy
pushed a commit
to Azure/azure-rest-api-specs
that referenced
this issue
Jul 12, 2016
* Need to make contents required since this is a PUT. Will add extensions that make it optional in C# and zero it out to an empty stream. * update documentation to reflect param required * undo this temp change Issue: Azure/autorest#884 is tracking support for this being an optional param properly and not resulting in a null reference. So I will keep this spec as is. * temp commit to remove the required flag We need a way to have template parameters not be required when they are in the host. I will work with Amar for this next week. * Revert "temp commit to remove the required flag" This reverts commit be8b7bf. * Work around for issue: 903 explicitly calling out our chunked transfer APIs until issue: Azure/autorest#903 is resolved. * Add missing method to delete all secrets in db In hyak, we could do this by simply excluding the parameter. That is not swagger compliant, so we need a separate entry. * Test out composites. * Remove composite specs since they don't work * update the required piece. * Try nesting again. * Removing get/set from descriptions latest generation tool automatically adds it. * Fixed to not remove "Gets " from method descript * Add the get back to globals. * make typefieldinfo an array. * Adding offset support for append operations This is an optional value used for unique implementations that know exactly where in the stream they want to begin appending data. * Add file already exists exception for webhdfs * Add BadOffsetException to swagger. * Fix issues with bad rebase had to copy back from azure and make the minor edits to these two .json files.
begoldsm
pushed a commit
to begoldsm/azure-rest-api-specs
that referenced
this issue
Aug 18, 2016
Will add extensions that make it optional in C# and zero it out to an empty stream. update documentation to reflect param required undo this temp change Issue: Azure/autorest#884 is tracking support for this being an optional param properly and not resulting in a null reference. So I will keep this spec as is. temp commit to remove the required flag We need a way to have template parameters not be required when they are in the host. I will work with Amar for this next week. Revert "temp commit to remove the required flag" This reverts commit be8b7bf. Work around for issue: 903 explicitly calling out our chunked transfer APIs until issue: Azure/autorest#903 is resolved. Add missing method to delete all secrets in db In hyak, we could do this by simply excluding the parameter. That is not swagger compliant, so we need a separate entry. Test out composites. Remove composite specs since they don't work update the required piece. Try nesting again. Removing get/set from descriptions latest generation tool automatically adds it. Fixed to not remove "Gets " from method descript Add the get back to globals. make typefieldinfo an array. Adding offset support for append operations This is an optional value used for unique implementations that know exactly where in the stream they want to begin appending data. Add file already exists exception for webhdfs Add BadOffsetException to swagger. Fix issues with bad rebase had to copy back from azure and make the minor edits to these two .json files. Update specs for ADLA hive properties Finalization of hive properties is in progress. Add new catalog API version this includes the new credential management layer. Move the get with other operations for credentials Add new property for job statistics finalizingTimeUtc which gives us information about when the job finalization started. Removing this update from master We are controlling this new update in a separate branch that is going to go live later.
amarzavery
pushed a commit
to Azure/azure-rest-api-specs
that referenced
this issue
Aug 18, 2016
* Need to make contents required since this is a PUT. Will add extensions that make it optional in C# and zero it out to an empty stream. update documentation to reflect param required undo this temp change Issue: Azure/autorest#884 is tracking support for this being an optional param properly and not resulting in a null reference. So I will keep this spec as is. temp commit to remove the required flag We need a way to have template parameters not be required when they are in the host. I will work with Amar for this next week. Revert "temp commit to remove the required flag" This reverts commit be8b7bf. Work around for issue: 903 explicitly calling out our chunked transfer APIs until issue: Azure/autorest#903 is resolved. Add missing method to delete all secrets in db In hyak, we could do this by simply excluding the parameter. That is not swagger compliant, so we need a separate entry. Test out composites. Remove composite specs since they don't work update the required piece. Try nesting again. Removing get/set from descriptions latest generation tool automatically adds it. Fixed to not remove "Gets " from method descript Add the get back to globals. make typefieldinfo an array. Adding offset support for append operations This is an optional value used for unique implementations that know exactly where in the stream they want to begin appending data. Add file already exists exception for webhdfs Add BadOffsetException to swagger. Fix issues with bad rebase had to copy back from azure and make the minor edits to these two .json files. Update specs for ADLA hive properties Finalization of hive properties is in progress. Add new catalog API version this includes the new credential management layer. Move the get with other operations for credentials Add new property for job statistics finalizingTimeUtc which gives us information about when the job finalization started. Removing this update from master We are controlling this new update in a separate branch that is going to go live later. * Update specs for ADLA hive properties Finalization of hive properties is in progress. Add new catalog API version this includes the new credential management layer. Move the get with other operations for credentials * Add new property for job statistics finalizingTimeUtc which gives us information about when the job finalization started. Removing this update from master We are controlling this new update in a separate branch that is going to go live later.
John-Hart
pushed a commit
to Azure/azure-rest-api-specs
that referenced
this issue
Aug 23, 2016
* Need to make contents required since this is a PUT. Will add extensions that make it optional in C# and zero it out to an empty stream. update documentation to reflect param required undo this temp change Issue: Azure/autorest#884 is tracking support for this being an optional param properly and not resulting in a null reference. So I will keep this spec as is. temp commit to remove the required flag We need a way to have template parameters not be required when they are in the host. I will work with Amar for this next week. Revert "temp commit to remove the required flag" This reverts commit be8b7bf. Work around for issue: 903 explicitly calling out our chunked transfer APIs until issue: Azure/autorest#903 is resolved. Add missing method to delete all secrets in db In hyak, we could do this by simply excluding the parameter. That is not swagger compliant, so we need a separate entry. Test out composites. Remove composite specs since they don't work update the required piece. Try nesting again. Removing get/set from descriptions latest generation tool automatically adds it. Fixed to not remove "Gets " from method descript Add the get back to globals. make typefieldinfo an array. Adding offset support for append operations This is an optional value used for unique implementations that know exactly where in the stream they want to begin appending data. Add file already exists exception for webhdfs Add BadOffsetException to swagger. Fix issues with bad rebase had to copy back from azure and make the minor edits to these two .json files. Update specs for ADLA hive properties Finalization of hive properties is in progress. Add new catalog API version this includes the new credential management layer. Move the get with other operations for credentials Add new property for job statistics finalizingTimeUtc which gives us information about when the job finalization started. Removing this update from master We are controlling this new update in a separate branch that is going to go live later. * Update specs for ADLA hive properties Finalization of hive properties is in progress. Add new catalog API version this includes the new credential management layer. Move the get with other operations for credentials * Add new property for job statistics finalizingTimeUtc which gives us information about when the job finalization started. Removing this update from master We are controlling this new update in a separate branch that is going to go live later. * Update job.json minor comment update to trigger python and node rebuild of SDK.
begoldsm
pushed a commit
to begoldsm/azure-rest-api-specs
that referenced
this issue
Aug 31, 2016
Will add extensions that make it optional in C# and zero it out to an empty stream. update documentation to reflect param required undo this temp change Issue: Azure/autorest#884 is tracking support for this being an optional param properly and not resulting in a null reference. So I will keep this spec as is. temp commit to remove the required flag We need a way to have template parameters not be required when they are in the host. I will work with Amar for this next week. Revert "temp commit to remove the required flag" This reverts commit be8b7bf. Work around for issue: 903 explicitly calling out our chunked transfer APIs until issue: Azure/autorest#903 is resolved. Add missing method to delete all secrets in db In hyak, we could do this by simply excluding the parameter. That is not swagger compliant, so we need a separate entry. Test out composites. Remove composite specs since they don't work update the required piece. Try nesting again. Removing get/set from descriptions latest generation tool automatically adds it. Fixed to not remove "Gets " from method descript Add the get back to globals. make typefieldinfo an array. Adding offset support for append operations This is an optional value used for unique implementations that know exactly where in the stream they want to begin appending data. Add file already exists exception for webhdfs Add BadOffsetException to swagger. Fix issues with bad rebase had to copy back from azure and make the minor edits to these two .json files. Update specs for ADLA hive properties Finalization of hive properties is in progress. Add new catalog API version this includes the new credential management layer. Move the get with other operations for credentials Add new property for job statistics finalizingTimeUtc which gives us information about when the job finalization started. Removing this update from master We are controlling this new update in a separate branch that is going to go live later. Update specs for ADLA hive properties Finalization of hive properties is in progress. Add new catalog API version this includes the new credential management layer. Move the get with other operations for credentials Add new property for job statistics finalizingTimeUtc which gives us information about when the job finalization started. Removing this update from master We are controlling this new update in a separate branch that is going to go live later. Update job.json minor comment update to trigger python and node rebuild of SDK. Update to use MSGetAclStatus for ADLS This keeps the existing behavior, which we need for proper presentation of ACLs in PowerShell. Add permission property to the AclStatus object The ACL status object now includes a permission property. Sticky bit is not supported so should not be modified.
amarzavery
pushed a commit
to Azure/azure-rest-api-specs
that referenced
this issue
Sep 1, 2016
* Need to make contents required since this is a PUT. Will add extensions that make it optional in C# and zero it out to an empty stream. update documentation to reflect param required undo this temp change Issue: Azure/autorest#884 is tracking support for this being an optional param properly and not resulting in a null reference. So I will keep this spec as is. temp commit to remove the required flag We need a way to have template parameters not be required when they are in the host. I will work with Amar for this next week. Revert "temp commit to remove the required flag" This reverts commit be8b7bf. Work around for issue: 903 explicitly calling out our chunked transfer APIs until issue: Azure/autorest#903 is resolved. Add missing method to delete all secrets in db In hyak, we could do this by simply excluding the parameter. That is not swagger compliant, so we need a separate entry. Test out composites. Remove composite specs since they don't work update the required piece. Try nesting again. Removing get/set from descriptions latest generation tool automatically adds it. Fixed to not remove "Gets " from method descript Add the get back to globals. make typefieldinfo an array. Adding offset support for append operations This is an optional value used for unique implementations that know exactly where in the stream they want to begin appending data. Add file already exists exception for webhdfs Add BadOffsetException to swagger. Fix issues with bad rebase had to copy back from azure and make the minor edits to these two .json files. Update specs for ADLA hive properties Finalization of hive properties is in progress. Add new catalog API version this includes the new credential management layer. Move the get with other operations for credentials Add new property for job statistics finalizingTimeUtc which gives us information about when the job finalization started. Removing this update from master We are controlling this new update in a separate branch that is going to go live later. Update specs for ADLA hive properties Finalization of hive properties is in progress. Add new catalog API version this includes the new credential management layer. Move the get with other operations for credentials Add new property for job statistics finalizingTimeUtc which gives us information about when the job finalization started. Removing this update from master We are controlling this new update in a separate branch that is going to go live later. Update job.json minor comment update to trigger python and node rebuild of SDK. Update to use MSGetAclStatus for ADLS This keeps the existing behavior, which we need for proper presentation of ACLs in PowerShell. Add permission property to the AclStatus object The ACL status object now includes a permission property. Sticky bit is not supported so should not be modified. * ADLS Swagger updates Adding support for: expiry (getting and setting) ACLs (return microsoft specific ACL information, and remove full acls and default acls) Missed file on previous commit. * fix tabbing and remove unused subscriptionID * Update the descriptions. * Enable Encryption support for ADLS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This was the default behavior previously (in hyak) and it is the best practice when sending stream content to the server, enabling the server and client to negotiate the best way to chunk the content and consume it.
The text was updated successfully, but these errors were encountered: