This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Move generating deprecation message inside of packages #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Feb 7, 2019
| @@ -152,6 +154,14 @@ protected async Task GenerateLicenseTxt(CodeModelJs codeModel, GeneratorSettings | |||
| } | |||
| } | |||
|
|
|||
| protected async Task GeneratePostinstallScript(CodeModelJs codeModel, GeneratorSettingsJs generatorSettings) | |||
There was a problem hiding this comment.
Suggested change
| protected async Task GeneratePostinstallScript(CodeModelJs codeModel, GeneratorSettingsJs generatorSettings) | |
| protected async Task GeneratePostInstallScript(CodeModelJs codeModel, GeneratorSettingsJs generatorSettings) |
Should install be captalized?
There was a problem hiding this comment.
The name of the file is "postinstall.js" so that's why I capitalized it like that. What do you think?
There was a problem hiding this comment.
That's fine with me. Leave it the way you have it.
🤖 AutoRest automatic feature coverage report 🤖feature set version 2.6.0 ❌️ General: 97%13 out of 540 features are not covered by tests
❌️ Azure: 96%4 out of 122 features are not covered by tests
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.