Remove string-dates flag

Azure · Mar 7, 2018 · 1f57f00 · 1f57f00
1 parent 9e99f4e
commit 1f57f00
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 16 deletions.
diff --git a/README.md b/README.md
@@ -44,10 +44,6 @@ This project enables Java code generation in [AutoRest](https://github.com/Azure
   - With Argument (`true`): `int Plus(@NonNull Integer val1, @NonNull Integer val2)`
 - *--java.required-parameter-client-methods*: Whether or not Service and Method Group client method overloads that omit optional parameters will be created.
   - Default: `true`
-- *--java.string-dates*: Whether or not DateTime types should be represented as Strings (generally for better/different precision).
-  - Default: `false`
-  - Without Argument: `public DateTime duration(DateTime startTime, DateTime endTime)`
-  - With Argument (`true`): `public String duration(String startTime, String endTime)`
 
 # Contributing
 

diff --git a/src/JavaCodeGenerator.cs b/src/JavaCodeGenerator.cs
@@ -154,7 +154,6 @@ public override Task Generate(AutoRestCodeModel codeModel)
                 package: codeModel.Namespace.ToLowerInvariant(),
                 shouldGenerateXmlSerialization: codeModel.ShouldGenerateXmlSerialization,
                 nonNullAnnotations: GetBoolSetting(autoRestSettings, "non-null-annotations", true),
-                stringDates: GetBoolSetting(autoRestSettings, "string-dates"),
                 clientTypePrefix: GetStringSetting(autoRestSettings, "client-type-prefix"),
                 generateClientInterfaces: GetBoolSetting(autoRestSettings, "generate-client-interfaces", true),
                 implementationSubpackage: GetStringSetting(autoRestSettings, "implementation-subpackage", "implementation"),
@@ -1428,13 +1427,13 @@ private static IType ParseType(AutoRestIModelType autoRestIModelType, JavaSettin
                             result = ArrayType.ByteArray;
                             break;
                         case AutoRestKnownPrimaryType.Date:
-                            result = settings.StringDates ? ClassType.String : ClassType.JodaLocalDate;
+                            result = ClassType.JodaLocalDate;
                             break;
                         case AutoRestKnownPrimaryType.DateTime:
-                            result = settings.StringDates ? ClassType.String : ClassType.JodaDateTime;
+                            result = ClassType.JodaDateTime;
                             break;
                         case AutoRestKnownPrimaryType.DateTimeRfc1123:
-                            result = settings.StringDates ? ClassType.String : ClassType.DateTimeRfc1123;
+                            result = ClassType.DateTimeRfc1123;
                             break;
                         case AutoRestKnownPrimaryType.Double:
                             result = PrimitiveType.Double;
@@ -1465,7 +1464,7 @@ private static IType ParseType(AutoRestIModelType autoRestIModelType, JavaSettin
                             result = ClassType.JodaPeriod;
                             break;
                         case AutoRestKnownPrimaryType.UnixTime:
-                            result = settings.StringDates ? (IType)ClassType.String : PrimitiveType.UnixTimeLong;
+                            result = PrimitiveType.UnixTimeLong;
                             break;
                         case AutoRestKnownPrimaryType.Uuid:
                             result = ClassType.UUID;

diff --git a/src/JavaSettings.cs b/src/JavaSettings.cs
@@ -44,7 +44,6 @@ public JavaSettings(
             string package,
             bool shouldGenerateXmlSerialization,
             bool nonNullAnnotations,
-            bool stringDates,
             string clientTypePrefix,
             bool generateClientInterfaces,
             string implementationSubpackage,
@@ -62,7 +61,6 @@ public JavaSettings(
             Package = package;
             ShouldGenerateXmlSerialization = shouldGenerateXmlSerialization;
             NonNullAnnotations = nonNullAnnotations;
-            StringDates = stringDates;
             ClientTypePrefix = clientTypePrefix;
             GenerateClientInterfaces = generateClientInterfaces;
             ImplementationSubpackage = implementationSubpackage;
@@ -100,11 +98,6 @@ public bool AddCredentials
         /// </summary>
         public bool NonNullAnnotations { get; }
 
-        /// <summary>
-        /// Whether or not DateTime types should be represented as Strings (generally for better/different precision).
-        /// </summary>
-        public bool StringDates { get; }
-
         /// <summary>
         /// The prefix that will be added to each generated client type.
         /// </summary>