Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wire path to properties when bicep serialization is turned on #4229

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

m-nash
Copy link
Member

@m-nash m-nash commented Feb 16, 2024

This is supporting this issue Azure/azure-sdk-for-net#41976

In order to support the expression builders in cdk we need to know given a specific property path what is the serialized path to this property.

For normal properties this is just the serialized name
image

For flattened properties this prepends the flattened name
image

For single property automated flatten it needs to get the name of the full stack as well
image

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@m-nash
Copy link
Member Author

m-nash commented Feb 16, 2024

/check-enforcer override

@m-nash m-nash merged commit 88d6712 into feature/v3 Feb 16, 2024
7 checks passed
@m-nash m-nash deleted the mnash-pathAttribute branch February 16, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants