Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dpg): incorrect enum convenience/protocol parameter conversion #3898

Merged
merged 8 commits into from
Nov 10, 2023
Merged

fix(dpg): incorrect enum convenience/protocol parameter conversion #3898

merged 8 commits into from
Nov 10, 2023

Conversation

archerzz
Copy link
Member

@archerzz archerzz commented Nov 2, 2023

Description

  • add missing logic to convert method parameter of int/float enum types from convenience to protocol
  • add temporary test case

fix #3881

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@archerzz
fix(dpg): incorrect enum convenience/protocol parameter conversion
ed33c4d 
- add missing logic to convert method parameter of int/float enum types from convenience to protocol
- add temporary test case

fix Azure#3881
@archerzz
Copy link
Member Author

archerzz commented Nov 2, 2023

We need to add some test cases in cadl-ranch later: https://github.com/Azure/cadl-ranch/tree/main/packages/cadl-ranch-specs/http/type/enum

@chunyu3
Copy link
Member

chunyu3 commented Nov 3, 2023 •
edited
Loading

@archerzz Please add tests in cadl-ranch.

@azure-sdk azure-sdk mentioned this pull request Nov 3, 2023
Closed
@archerzz
Copy link
Member Author

archerzz commented Nov 3, 2023

Regen Preview: Azure/azure-sdk-for-net#39720

No actual change

@JoshLove-msft
Copy link
Member

Can this be merged?

@archerzz
Copy link
Member Author

archerzz commented Nov 9, 2023

blocked by #3917

@archerzz archerzz merged commit 2134917 into Azure:feature/v3 Nov 10, 2023
7 checks passed
@archerzz archerzz deleted the fix-enum-convenience-protocol-param-conversion branch November 10, 2023 02:32
@archerzz
Copy link
Member Author

@JoshLove-msft This PR has been merged. It should unblock your work on the enum parameters.

live1206 pushed a commit to live1206/autorest.csharp that referenced this pull request Dec 11, 2023
@archerzz @live1206
fix(dpg): incorrect enum convenience/protocol parameter conversion (A…
8e2d9fe 
…zure#3898)

- add missing logic to convert method parameter of int/float enum types from convenience to protocol
- add temporary test case

fix Azure#3881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes

@ArthurMa1978 ArthurMa1978 ArthurMa1978 approved these changes

@chunyu3 chunyu3 chunyu3 approved these changes

@lirenhe lirenhe lirenhe approved these changes

@m-nash m-nash Awaiting requested review from m-nash

@jsquire jsquire Awaiting requested review from jsquire

@hallipr hallipr Awaiting requested review from hallipr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated code using an enum of ints does not compile
5 participants
@archerzz @chunyu3 @JoshLove-msft @lirenhe @ArthurMa1978