Change the way we get plural resource names #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/AutoRest.CSharp/Mgmt/Generation/SubscriptionExtensionsWriter.cs
ArcturusZhang
requested review from
AlexanderSher,
allenjzhang,
m-nash and
ShivangiReja
as code owners
…we-get-plural # Conflicts: # src/AutoRest.CSharp/AutoRest.CSharp.csproj
samples/Azure.ResourceManager.Sample/Generated/Extensions/ArmClientExtensions.cs
Outdated
Show resolved
Hide resolved
…we-get-plural # Conflicts: # src/AutoRest.CSharp/AutoRest.CSharp.csproj
|
LGTM |
fengzhou-msft
approved these changes
Dec 16, 2021
archerzz
pushed a commit
to archerzz/autorest.csharp
that referenced
this pull request
Dec 17, 2021
* change the way we get plural and singular form of resource names # Conflicts: # src/AutoRest.CSharp/Mgmt/Generation/SubscriptionExtensionsWriter.cs * fix exception and regenerate * add test cases * move the ResourceNameToPlural to mgmt namespace * regenerate * fix a bug in toSingular * regenerate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LastWordToPlural()instead which will first split the string into words, and change the last word to its plural form, then concat them back. This will give us more accurate result, such as, we will get the plural form ofKeyInformationto beKeyInformationinstead ofKeyInformationssinceinformationis uncountable.Humanizerthat if I call"S".Singularize(), it throws exceptions. Unfortunately our test project has this case. I have to make a work around.Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?