-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure/arm-deploy@v1 fails after new release of Azure CLI Version 2.24.1 #48
Comments
This issue is marked default for generating issues report. |
We are running into a similar issue on Linux runners. |
@mburuckercSO @JaMatus Can you please share the workflow file? |
@t-dedah sure 🙂 here is the release workflow file:
|
This issue is marked default for generating issues report. |
I am experiencing the same issue. It does not matter which ARM template you are deploying. It fails whatever you are trying to deploy. |
I am seeing this issue too. There seems to be a warning being displayed before the failure,not sure if it is related but here is the relevant log from a run today. I hadn't seen any warnings prior to todays runs. 2021-06-03T10:54:38.6823203Z ##[endgroup] |
This issue is marked default for generating issues report. |
I am seeing this issue as well. I will mention the Azure portal is showing the deployment as succesful, and I have verified that the resources have been created/changed. |
I can confirm this. Validation still works fine, but also shows the warning. |
I can confirm that I am seeing the same errors and my deployment was successful |
Seeing the same issue also this morning |
Seeing the same issue. |
This issue is marked default for generating issues report. |
I wonder if it's related to Azure/azure-cli#18262 (though that was reported earlier, for 2.24.0). |
Seeing this issue as well. Is anyone aware of any workarounds? |
If you don't need any outputs we simply used |
I did, @elizabethlfransen, but as it turns out the outputs are missing in the from the step. |
@iamalexmang Yeah when it errors out there wont be any outputs. I was lucky to be in a case where we didn't need the outputs |
This issue is marked default for generating issues report. |
Hi @t-dedah, is there any ETA on a permanent fix for v1? |
This issue is marked default for generating issues report. |
@parallo-mattallford @plzm @dico-harigkev fix has been released by azure-cli team but public agent pool is yet to be updated to use upgrade azure-cli, I am trying to get updates for this. |
@dico-harigkev @plzm Can you please share more info to investigate better
|
This is the schedule for next image rollout for the public agents. After this new fix should be available to everyone. Please test with V1 after this. Windows 2019 - Fri /Mon |
@dico-harigkev @parallo-mattallford @plzm we are looking at the issue of action reporting success even if deployment fails. |
@t-dedah / @bishal-pdMSFT - can we please look into setting the az cli version if the task is going to take that dependency? Otherwise, we expose our customers to breaking changes like this with no good workarounds.. Alternatively, can we take advantage of the version in the task name (i.e. For the other folks on the thread that have experienced this issue, why not use the |
@ashmind and I made this point above about making the CLI version a parameter. I think it should be decoupled from the version number of this action though and supplied in the I did briefly look into making this change, but it looks like the AZ cli is pre-installed on the hosts so this action is just implicitly relying on whatever version is already installed. I think that means it would be quite a bit of work to allow the version to be set as an install step for the CLI would have to be added first. Maybe a I do agree with you though that this wrapper action seems to be causing more harm than good given it's such a thin layer of indirection. |
Also I think all of the errors being reported here about the action reporting success even though the deployment failed are a direct consequence of the workaround that's been applied to |
@parallo-mattallford @plzm @dico-harigkev I tried to repro the issue with a template deployment but it succeeded for me. Will it be possible to provide me with repro steps ? |
Alex, I believe the main reason for picking this action in particular rather than using Az CLI was driven by these two ideas:
* hooking up the output to a variable in the workflow, which would otherwise require handling the success/failure of the command, parsing of the command output and pulling the ARM output and then finally hooking _that_ output up with the GitHub workflow using environment variables. Quite messy stuff, I’d add; I believe I’d rather develop a task which does a REST API calls instead to handle parsing of the output correctly, though this would imply considerable more development effort for us
* There was an assumption that the action leverages the REST API and is stable enough to prevent dependency breaking changes. That was clearly a false assumption.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Matt Thornton ***@***.***>
Sent: Thursday, June 17, 2021 7:13:16 PM
To: Azure/arm-deploy ***@***.***>
Cc: Alex Mang ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/arm-deploy] ***@***.*** fails after new release of Azure CLI Version 2.24.1 (#48)
Also I think all of the errors being reported here about the action reporting success even though the deployment failed are a direct consequence of the workaround that's been applied to main. I believe #50<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Farm-deploy%2Fpull%2F50&data=04%7C01%7Camang%40keyticket.eu%7C45a6b34ea42946f914ff08d931aad188%7Cbeaab1c6c6ce475092dacac20ae5d13a%7C1%7C0%7C637595432007446268%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=2rP%2FZW4%2BqSzQzuP9PDNtuJDCoGN8Q1O20Oed7epYcoo%3D&reserved=0> disabled checking stderr because the CLI was erroneously writing whitespace to stderr, so it doesn't seem surprising that as a consequence of this workaround the action will now succeed even when they are errors.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Farm-deploy%2Fissues%2F48%23issuecomment-863374028&data=04%7C01%7Camang%40keyticket.eu%7C45a6b34ea42946f914ff08d931aad188%7Cbeaab1c6c6ce475092dacac20ae5d13a%7C1%7C0%7C637595432007446268%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Q7vhE392onrIdjlc1HNleqmfw6TyCqPDcdQ9Xaon%2BHo%3D&reserved=0>, or unsubscribe<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABMBPYJPDNNRBQZMOZKNMZ3TTINJZANCNFSM456PX5SA&data=04%7C01%7Camang%40keyticket.eu%7C45a6b34ea42946f914ff08d931aad188%7Cbeaab1c6c6ce475092dacac20ae5d13a%7C1%7C0%7C637595432007456262%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=99KGGO87qRPVgL8G4F7HHMd1VwcLLerdq29SjU5JsLs%3D&reserved=0>.
|
Thanks @t-dedah - see a workflow run here: I have run a variety of ARM templates in this repo, all exhibit the same behavior. |
@parallo-mattallford @plzm @dico-harigkev We have fixed the |
This issue is marked default for generating issues report. |
Fix for this issue has been released to v1 version. |
Those who moved to
instead of using main |
This issue is stale because it has been open for 7 days with no activity. |
Closing this issue as fixed has been deployed. |
A RCA of this issue has been posted here. Please feel free to put your comments. |
Hello 🙂 Since the new release (1. June 2021) of Azure CLI Version 2.24.1, our github actions deployment to azure fails on azure/arm-deploy@v1 with following error:
The process 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd' failed because one or more lines were written to the STDERR stream
Have you experienced similar problem or this is not related in your opinion?
Thanks
The text was updated successfully, but these errors were encountered: