Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: kube-proxy image on Azure Stack deployments #4329

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

jadarsie
Copy link
Member

@jadarsie jadarsie commented Mar 16, 2021

Reason for Change:

Disconnected deployments on ASH using v0.61.0 fail as the kube-proxy manifest is referencing an image that is not present in the VHD. I suspect this was introduced by #4249.

As v1.16 is now unsupported, it should be safe to return to how things were before #3529.

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #4329 (f1704c7) into master (177303c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4329      +/-   ##
==========================================
- Coverage   72.06%   72.06%   -0.01%     
==========================================
  Files         141      141              
  Lines       21634    21633       -1     
==========================================
- Hits        15590    15589       -1     
  Misses       5093     5093              
  Partials      951      951              
Impacted Files Coverage Δ
pkg/api/addons.go 98.02% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23240ca...f1704c7. Read the comment docs.

@jadarsie jadarsie requested a review from jackfrancis March 16, 2021 18:16
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis jackfrancis merged commit 75d6b07 into Azure:master Mar 17, 2021
@acs-bot
Copy link

acs-bot commented Mar 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,jadarsie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants