Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: remove support for Kubernetes 1.15 #3751

Merged
merged 4 commits into from
Oct 14, 2020

Conversation

mboersma
Copy link
Member

Reason for Change:

This PR removes support for creating new clusters with Kubernetes 1.15.

Issue Fixed:

Fixes #3631

Requirements:

Notes:

@@ -3,7 +3,7 @@
"GINKGO_FOCUS": "should apply various network policies"
},
"options": {
"allowedOrchestratorVersions": ["1.15"]
"allowedOrchestratorVersions": []
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will delete this test config entirely

@jadarsie
Copy link
Member

jadarsie commented Aug 26, 2020

A bunch of these {{- if IsKubernetesVersionGe "1.16.0"}} can be removed from the templates under parts/k8s.

Example: https://github.com/Azure/aks-engine/blob/master/parts/k8s/addons/kube-proxy.yaml#L51-L54

@mboersma
Copy link
Member Author

{{- if IsKubernetesVersionGe "1.16.0"}} can be removed from the templates

You are so right! Thanks, I'll make those changes and update this PR.

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@0b6b43b). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3751   +/-   ##
=========================================
  Coverage          ?   72.79%           
=========================================
  Files             ?      149           
  Lines             ?    23158           
  Branches          ?        0           
=========================================
  Hits              ?    16858           
  Misses            ?     5183           
  Partials          ?     1117           
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.37% <ø> (ø)
pkg/engine/template_generator.go 81.31% <ø> (ø)
pkg/engine/templates_generated.go 48.97% <ø> (ø)
pkg/api/addons.go 97.75% <100.00%> (ø)
pkg/engine/artifacts.go 98.95% <0.00%> (ø)
pkg/api/agentPoolOnlyApi/v20170831/merge.go 0.00% <0.00%> (ø)
pkg/armhelpers/azurestack/compute.go 31.57% <0.00%> (ø)
pkg/engine/networksecuritygroups.go 100.00% <0.00%> (ø)
pkg/engine/userassignedidentities.go 100.00% <0.00%> (ø)
cmd/generate.go 49.18% <0.00%> (ø)
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b6b43b...d22820e. Read the comment docs.

@acs-bot acs-bot added size/XXL and removed size/XL labels Aug 26, 2020
@mboersma mboersma force-pushed the remove-1.15 branch 2 times, most recently from f665584 to 2130e3f Compare August 31, 2020 21:19
@mboersma mboersma force-pushed the remove-1.15 branch 2 times, most recently from ed6422d to 179b4ff Compare September 11, 2020 18:52
jackfrancis
jackfrancis previously approved these changes Oct 13, 2020
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Oct 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot
Copy link

acs-bot commented Oct 13, 2020

New changes are detected. LGTM label has been removed.

@jackfrancis jackfrancis merged commit 8a32382 into Azure:master Oct 14, 2020
@mboersma mboersma deleted the remove-1.15 branch October 14, 2020 17:08
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Kubernetes v1.15 support
4 participants