Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

docs: update limitations in dualstack docs #3727

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

aramase
Copy link
Member

@aramase aramase commented Aug 18, 2020

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@aramase aramase changed the title doc: update limitations in dualstack docs docs: update limitations in dualstack docs Aug 18, 2020
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #3727 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3727   +/-   ##
=======================================
  Coverage   73.16%   73.16%           
=======================================
  Files         147      147           
  Lines       25318    25318           
=======================================
  Hits        18525    18525           
  Misses       5655     5655           
  Partials     1138     1138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e748713...46061cf. Read the comment docs.

@jsturtevant
Copy link
Contributor

Should we add a message about windows support #3688?

@aramase
Copy link
Member Author

aramase commented Aug 18, 2020

Should we add a message about windows support #3688?

Dualstack support for windows is added only in 1.19 and I was thinking we can add a message for windows in the doc once 1.19 is released? WDYT?

The validation check needs to be removed only after the backport is complete, right?

@jsturtevant
Copy link
Contributor

Sorry I wasn't clear. I wanted to add a note to make it clear that Windows is not supported at this time because it requires 1.19 and backport to 2004.

@aramase
Copy link
Member Author

aramase commented Aug 18, 2020

Sorry I wasn't clear. I wanted to add a note to make it clear that Windows is not supported at this time because it requires 1.19 and backport to 2004.

Ah, that makes sense. Let me add that.

@jsturtevant
Copy link
Contributor

Thanks!

/lgtm

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis jackfrancis merged commit ae10679 into Azure:master Aug 19, 2020
@acs-bot
Copy link

acs-bot commented Aug 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, jackfrancis, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,jsturtevant]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aramase aramase deleted the dualstack-doc branch August 19, 2020 00:14
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants