This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: Give cluster-autoscaler permission to list replicasets.apps #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm pending E2E Thanks @mhyllander! |
|
@mhyllander I think it should be fine. I'll defer to @feiskyer for his thoughts as well. |
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
=======================================
Coverage 53.25% 53.25%
=======================================
Files 95 95
Lines 14246 14246
=======================================
Hits 7586 7586
Misses 5995 5995
Partials 665 665 |
|
@tariq1890 you can use /hold if you want to be sure a PR doesn't merge while waiting for additional confirmation /hold |
|
/lgtm |
tariq1890
approved these changes
Jan 10, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, jackfrancis, mhyllander, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jackfrancis
pushed a commit
that referenced
this pull request
Jan 11, 2019
juhacket
pushed a commit
to juhacket/aks-engine
that referenced
this pull request
Mar 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The cluster-autoscaler needs permission to list replicasets.apps resources.
Issue Fixed:
Fixes #261
Requirements:
Notes:
@tariq1890 I created the PR as you suggested, however my issue was for k8s 1.13.1. Will this fix work with previous k8s versions?