-
Notifications
You must be signed in to change notification settings - Fork 522
chore: update cluster-autoscaler to latest patch releases #2038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2038 +/- ##
=======================================
Coverage 76.67% 76.67%
=======================================
Files 135 135
Lines 20564 20564
=======================================
Hits 15768 15768
Misses 3877 3877
Partials 919 919 |
@marosset Should we be running the actual E2E tests against the Windows VHD CI job? In the Linux VHD Pipeline job we just run the VHD CI scripts and validate zero exit code. (I think that's what we should be doing for the Windows job, but maybe I'm missing some context?) |
@jackfrancis we did intend to run the actual E2E tests against the Windows VHD CI job. |
@marosset that makes sense, I actually think we could use that strategy for Linux as well to our benefit. Does it make sense that the changeset in this PR would kick off the Windows VHD CI? I would assume those changes are Linux only, but perhaps I'm not aware of some tasty code re-use in that file. :) |
@jackfrancis currently any changes in /packer/ (and this PR updates packer/install-dependencies.sh) will trigger the Windows VHD but i don't think it makes sense to run that here. I'll update the trigger to be something like /packer/windows for now and we can look into splitting packer/ into packer/linux/ and packer/windows/ in the near future to avoid running the linux VHD CI for windows only changes |
Reason for Change:
See https://github.com/kubernetes/autoscaler/releases. Some minor fixes are included in each patch.
Issue Fixed:
Requirements:
Notes: