Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: remove no-op 1.15 version checks in templates #3851

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

mboersma
Copy link
Member

Reason for Change:

Since AKS Engine already supports only Kubernetes v1.15.x or later, these template conditionals have no effect.

Issue Fixed:

Refs #3751

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

Requirements:

Notes:

Thanks to @jadarsie for noticing the off-by-one error in #3751, which implies this cleanup.

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #3851 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3851   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         149      149           
  Lines       23171    23171           
=======================================
  Hits        16876    16876           
  Misses       5178     5178           
  Partials     1117     1117           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 48.65% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e34a3...a3fb096. Read the comment docs.

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Sep 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma merged commit c8f0756 into Azure:master Sep 21, 2020
@mboersma mboersma deleted the cruft-removal branch September 21, 2020 19:49
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants