Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: revert 'trust Azure Stack's CA cert before pre-provision extensions' #2135

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

jadarsie
Copy link
Member

@jadarsie jadarsie commented Oct 9, 2019

Reason for Change:
We have a bizarre DNS issue that I think is caused by this #2053.
Reverting until we figure out what's going on.

@acs-bot acs-bot added the size/S label Oct 9, 2019
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Oct 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #2135 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2135   +/-   ##
=======================================
  Coverage   76.56%   76.56%           
=======================================
  Files         135      135           
  Lines       20685    20685           
=======================================
  Hits        15838    15838           
  Misses       3924     3924           
  Partials      923      923

@jadarsie
Copy link
Member Author

jadarsie commented Oct 10, 2019

@jackfrancis, the checks are not reflecting the pipeline status, it looks like it is done
https://dev.azure.com/aks-engine/AKS-Engine/_build/results?buildId=2758

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants