Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: trust Azure Stack's CA cert before pre-provision extensions are exectuted #2053

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Conversation

deaborch
Copy link
Contributor

Reason for Change:

Cluster pre-provisioning was failing on Azurestack due to an untrusted certificate on the host preventing the pre-provisioning scripts from being downloaded

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/S label Sep 27, 2019
@jadarsie jadarsie changed the title fix: fixes cluster preprovisioning script download on azurestack. fix: trust Azure Stack's CA cert before pre-provision extensions are exectuted Sep 27, 2019
@jadarsie
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rjaini rjaini requested a review from jackfrancis September 30, 2019 17:02
@jackfrancis
Copy link
Member

@deaborch During this work spike were you able to validate that pre-provision extensions are working for public cloud?

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Sep 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deaborch, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deaborch
Copy link
Contributor Author

@jackfrancis haven't been able to test on azure yet as I am looking into getting the telemetry fix up

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants