This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
fix race condition bug with kubectl returning nodes #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfrancis
approved these changes
Dec 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pr fixes a race condition with the monitoring (prometheus-grafana-k8s) extension. Thanks to @sozercan who uncovered this, showing the following output from logs:
The output of this log message shows that
kubectl get noreturned no nodes at this point in the extension execution (the final part of this log message should be a single node name, whereas in the above log message it is a null/empty string). This is a problem because no master node continued execution of the extension therefore prometheus and grafana helm charts were not installed.This pr fixes this bug to handle the case where
kubectl get nodoesn't return any nodes initially.// cc @ritazh