This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Improvements to throwIf methods #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljurek
approved these changes
May 10, 2018
| => o ?? throw (calledFromMember == ".ctor" | ||
| ? (Exception)new ArgumentNullException( | ||
| paramName, | ||
| $"Null argument {paramName} passed to {calledFromMember}in file {calledFromFile} at line {sourceLineNumber}" |
There was a problem hiding this comment.
The call stack will already have the calling method name, file, and line number info. Not sure if it's valuable to keep in here.
Also, if you do keep it, put a space between {calledFromMember}in...
| $"{paramName} found to be null or whitespace in method {calledFromMember} in file {calledFromFile} at line {sourceLineNumber}", | ||
| paramName | ||
| ) | ||
| : new NullReferenceException( |
There was a problem hiding this comment.
Nitpicking: If you're checking for whitespace/empty string you might want to throw an ArgumentException when the value is an empty or whitespace string.
| [CallerLineNumber]int sourceLineNumber = -1 | ||
| ) where TParam : class | ||
| => o ?? throw (calledFromMember == ".ctor" | ||
| ? (Exception)new ArgumentNullException( |
There was a problem hiding this comment.
One weird corner case would be if the constructor was throwing because of null when checking something that's not an argument:
private object resultFromSomeMethod;
public MyClass(string param)
{
this.resultFromSomeMethod = SomeMethod(param);
ThrowIf.Null(this.resultFromSomeMethod);
}
Not sure if/how we should handle that scenario outside of using code analysis at build time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to improve tracing and increase flexibility of usage