Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Updated tags to AVM standard - Batch 2 #4160

Merged
merged 4 commits into from
Oct 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion modules/insights/action-group/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,6 @@ The list of SMS receivers that are part of this action group.
Tags of the resource.
- Required: No
- Type: object
- Default: `{object}`

### Parameter: `voiceReceivers`

Expand Down
2 changes: 1 addition & 1 deletion modules/insights/action-group/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ param azureFunctionReceivers array = []
param armRoleReceivers array = []

@description('Optional. Tags of the resource.')
param tags object = {}
param tags object?

@description('Optional. Enable telemetry via a Globally Unique Identifier (GUID).')
param enableDefaultTelemetry bool = true
Expand Down
4 changes: 2 additions & 2 deletions modules/insights/action-group/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.22.6.54827",
"templateHash": "38103589755829738"
"templateHash": "2140251667223898817"
},
"name": "Action Groups",
"description": "This module deploys an Action Group.",
Expand Down Expand Up @@ -178,7 +178,7 @@
},
"tags": {
"type": "object",
"defaultValue": {},
"nullable": true,
"metadata": {
"description": "Optional. Tags of the resource."
}
Expand Down
1 change: 0 additions & 1 deletion modules/insights/activity-log-alert/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,6 @@ The list of resource IDs that this Activity Log Alert is scoped to.
Tags of the resource.
- Required: No
- Type: object
- Default: `{object}`


## Outputs
Expand Down
2 changes: 1 addition & 1 deletion modules/insights/activity-log-alert/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ param conditions array
param roleAssignments roleAssignmentType

@description('Optional. Tags of the resource.')
param tags object = {}
param tags object?

@description('Optional. Enable telemetry via a Globally Unique Identifier (GUID).')
param enableDefaultTelemetry bool = true
Expand Down
4 changes: 2 additions & 2 deletions modules/insights/activity-log-alert/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.22.6.54827",
"templateHash": "16411085736743453279"
"templateHash": "11464845772829048576"
},
"name": "Activity Log Alerts",
"description": "This module deploys an Activity Log Alert.",
Expand Down Expand Up @@ -138,7 +138,7 @@
},
"tags": {
"type": "object",
"defaultValue": {},
"nullable": true,
"metadata": {
"description": "Optional. Tags of the resource."
}
Expand Down
1 change: 0 additions & 1 deletion modules/insights/component/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,6 @@ Percentage of the data produced by the application being monitored that is being
Tags of the resource.
- Required: No
- Type: object
- Default: `{object}`

### Parameter: `workspaceResourceId`

Expand Down
2 changes: 1 addition & 1 deletion modules/insights/component/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ param location string = resourceGroup().location
param roleAssignments roleAssignmentType

@description('Optional. Tags of the resource.')
param tags object = {}
param tags object?

@description('Optional. Enable telemetry via a Globally Unique Identifier (GUID).')
param enableDefaultTelemetry bool = true
Expand Down
4 changes: 2 additions & 2 deletions modules/insights/component/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.22.6.54827",
"templateHash": "803183035503673320"
"templateHash": "15854449149260650767"
},
"name": "Application Insights",
"description": "This component deploys an Application Insights instance.",
Expand Down Expand Up @@ -281,7 +281,7 @@
},
"tags": {
"type": "object",
"defaultValue": {},
"nullable": true,
"metadata": {
"description": "Optional. Tags of the resource."
}
Expand Down
1 change: 0 additions & 1 deletion modules/insights/data-collection-endpoint/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,6 @@ Required. The name of the role to assign. If it cannot be found you can specify
Resource tags.
- Required: No
- Type: object
- Default: `{object}`


## Outputs
Expand Down
2 changes: 1 addition & 1 deletion modules/insights/data-collection-endpoint/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ param roleAssignments roleAssignmentType
param publicNetworkAccess string = 'Disabled'

@description('Optional. Resource tags.')
param tags object = {}
param tags object?

var builtInRoleNames = {
Contributor: subscriptionResourceId('Microsoft.Authorization/roleDefinitions', 'b24988ac-6180-42a0-ab88-20f7382dd24c')
Expand Down
4 changes: 2 additions & 2 deletions modules/insights/data-collection-endpoint/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.22.6.54827",
"templateHash": "5064319070805092308"
"templateHash": "8921941475150538433"
},
"name": "Data Collection Endpoints",
"description": "This module deploys a Data Collection Endpoint.",
Expand Down Expand Up @@ -162,7 +162,7 @@
},
"tags": {
"type": "object",
"defaultValue": {},
"nullable": true,
"metadata": {
"description": "Optional. Resource tags."
}
Expand Down
1 change: 0 additions & 1 deletion modules/insights/data-collection-rule/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1671,7 +1671,6 @@ Declaration of custom streams used in this rule.
Resource tags.
- Required: No
- Type: object
- Default: `{object}`


## Outputs
Expand Down
2 changes: 1 addition & 1 deletion modules/insights/data-collection-rule/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ param roleAssignments roleAssignmentType
param streamDeclarations object = {}

@sys.description('Optional. Resource tags.')
param tags object = {}
param tags object?

// =============== //
// Deployments //
Expand Down
4 changes: 2 additions & 2 deletions modules/insights/data-collection-rule/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.22.6.54827",
"templateHash": "12929247318394653560"
"templateHash": "2029998281934386338"
},
"name": "Data Collection Rules",
"description": "This module deploys a Data Collection Rule.",
Expand Down Expand Up @@ -190,7 +190,7 @@
},
"tags": {
"type": "object",
"defaultValue": {},
"nullable": true,
"metadata": {
"description": "Optional. Resource tags."
}
Expand Down
1 change: 0 additions & 1 deletion modules/insights/metric-alert/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,6 @@ The severity of the alert.
Tags of the resource.
- Required: No
- Type: object
- Default: `{object}`

### Parameter: `targetResourceRegion`

Expand Down
2 changes: 1 addition & 1 deletion modules/insights/metric-alert/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ param criterias array
param roleAssignments roleAssignmentType

@description('Optional. Tags of the resource.')
param tags object = {}
param tags object?

@description('Optional. Enable telemetry via a Globally Unique Identifier (GUID).')
param enableDefaultTelemetry bool = true
Expand Down
4 changes: 2 additions & 2 deletions modules/insights/metric-alert/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.22.6.54827",
"templateHash": "12768498740595616170"
"templateHash": "7986480211513146761"
},
"name": "Metric Alerts",
"description": "This module deploys a Metric Alert.",
Expand Down Expand Up @@ -216,7 +216,7 @@
},
"tags": {
"type": "object",
"defaultValue": {},
"nullable": true,
"metadata": {
"description": "Optional. Tags of the resource."
}
Expand Down
1 change: 0 additions & 1 deletion modules/insights/private-link-scope/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,6 @@ Configuration details for Azure Monitor Resources.
Resource tags.
- Required: No
- Type: object
- Default: `{object}`


## Outputs
Expand Down
2 changes: 1 addition & 1 deletion modules/insights/private-link-scope/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ param scopedResources array = []
param privateEndpoints privateEndpointType

@description('Optional. Resource tags.')
param tags object = {}
param tags object?

@description('Optional. Enable telemetry via a Globally Unique Identifier (GUID).')
param enableDefaultTelemetry bool = true
Expand Down
4 changes: 2 additions & 2 deletions modules/insights/private-link-scope/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.22.6.54827",
"templateHash": "9175020405944005574"
"templateHash": "10939592682328481507"
},
"name": "Azure Monitor Private Link Scopes",
"description": "This module deploys an Azure Monitor Private Link Scope.",
Expand Down Expand Up @@ -296,7 +296,7 @@
},
"tags": {
"type": "object",
"defaultValue": {},
"nullable": true,
"metadata": {
"description": "Optional. Resource tags."
}
Expand Down
1 change: 0 additions & 1 deletion modules/insights/scheduled-query-rule/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,6 @@ Mute actions for the chosen period of time (in ISO 8601 duration format) after t
Tags of the resource.
- Required: No
- Type: object
- Default: `{object}`

### Parameter: `targetResourceTypes`

Expand Down
2 changes: 1 addition & 1 deletion modules/insights/scheduled-query-rule/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ param criterias object
param suppressForMinutes string = ''

@description('Optional. Tags of the resource.')
param tags object = {}
param tags object?

@description('Optional. Enable telemetry via a Globally Unique Identifier (GUID).')
param enableDefaultTelemetry bool = true
Expand Down
4 changes: 2 additions & 2 deletions modules/insights/scheduled-query-rule/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.22.6.54827",
"templateHash": "12829815846590991969"
"templateHash": "3215598878486027169"
},
"name": "Scheduled Query Rules",
"description": "This module deploys a Scheduled Query Rule.",
Expand Down Expand Up @@ -209,7 +209,7 @@
},
"tags": {
"type": "object",
"defaultValue": {},
"nullable": true,
"metadata": {
"description": "Optional. Tags of the resource."
}
Expand Down
1 change: 0 additions & 1 deletion modules/key-vault/vault/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1269,7 +1269,6 @@ softDelete data retention days. It accepts >=7 and <=90.
Resource tags.
- Required: No
- Type: object
- Default: `{object}`

### Parameter: `vaultSku`

Expand Down
1 change: 0 additions & 1 deletion modules/key-vault/vault/key/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ Key rotation policy properties object.
Resource tags.
- Required: No
- Type: object
- Default: `{object}`


## Outputs
Expand Down
2 changes: 1 addition & 1 deletion modules/key-vault/vault/key/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ param keyVaultName string
param name string

@description('Optional. Resource tags.')
param tags object = {}
param tags object?

@description('Optional. Determines whether the object is enabled.')
param attributesEnabled bool = true
Expand Down
4 changes: 2 additions & 2 deletions modules/key-vault/vault/key/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.22.6.54827",
"templateHash": "15473816229466025012"
"templateHash": "2953672245031093442"
},
"name": "Key Vault Keys",
"description": "This module deploys a Key Vault Key.",
Expand Down Expand Up @@ -95,7 +95,7 @@
},
"tags": {
"type": "object",
"defaultValue": {},
"nullable": true,
"metadata": {
"description": "Optional. Resource tags."
}
Expand Down
6 changes: 3 additions & 3 deletions modules/key-vault/vault/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ param roleAssignments roleAssignmentType
param privateEndpoints privateEndpointType

@description('Optional. Resource tags.')
param tags object = {}
param tags object?

@description('Optional. Enable telemetry via a Globally Unique Identifier (GUID).')
param enableDefaultTelemetry bool = true
Expand Down Expand Up @@ -212,7 +212,7 @@ module keyVault_secrets 'secret/main.bicep' = [for (secret, index) in secretList
attributesExp: contains(secret, 'attributesExp') ? secret.attributesExp : -1
attributesNbf: contains(secret, 'attributesNbf') ? secret.attributesNbf : -1
contentType: contains(secret, 'contentType') ? secret.contentType : ''
tags: contains(secret, 'tags') ? secret.tags : {}
tags: secret.?tags ?? tags
roleAssignments: contains(secret, 'roleAssignments') ? secret.roleAssignments : []
enableDefaultTelemetry: enableReferencedModulesTelemetry
}
Expand All @@ -230,7 +230,7 @@ module keyVault_keys 'key/main.bicep' = [for (key, index) in keys: {
keyOps: contains(key, 'keyOps') ? key.keyOps : []
keySize: contains(key, 'keySize') ? key.keySize : -1
kty: contains(key, 'kty') ? key.kty : 'EC'
tags: contains(key, 'tags') ? key.tags : {}
tags: key.?tags ?? tags
roleAssignments: contains(key, 'roleAssignments') ? key.roleAssignments : []
enableDefaultTelemetry: enableReferencedModulesTelemetry
rotationPolicy: contains(key, 'rotationPolicy') ? key.rotationPolicy : {}
Expand Down
Loading