Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Added WEBSITE_CONTENTAZUREFILECONNECTIONSTRING to app settings #3885

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PoojithJain
Copy link

@PoojithJain PoojithJain commented Aug 31, 2023

Description

Added WEBSITE_CONTENTAZUREFILECONNECTIONSTRING to app settings to store binaries in blob

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@PoojithJain PoojithJain requested a review from a team as a code owner August 31, 2023 14:23
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Aug 31, 2023
@AlexanderSehr AlexanderSehr changed the title Added WEBSITE_CONTENTAZUREFILECONNECTIONSTRING to app settings to sto… [Modules] Added WEBSITE_CONTENTAZUREFILECONNECTIONSTRING to app settings Aug 31, 2023
@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Aug 31, 2023

Mr. @PoojithJain,

thank you for your contribution. A short ask: Would you have a test environment available to test the change? Even better - would you have a pipeline badge available that shows that the change works?

If not, we have 2 options. Either

  • You set one up and attach the pipeline badge to the PR, or
  • We can change the target branch to a dev branch I can create on our end, to test the update on our end

I'd probably also suggest to extend one of the test cases to make use of the storage parameter to test if the logic is sound :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants