Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Utility] Created REST-2-CARML module that allows users to generate most of a module's code for them #2130

Draft
wants to merge 142 commits into
base: main
Choose a base branch
from
Draft

[Utility] Created REST-2-CARML module that allows users to generate most of a module's code for them #2130

wants to merge 142 commits into from

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Sep 24, 2022 •
edited
Loading

Description

  • A REST-2-CARML module that allows users to generate most of a module's code for them

    • Module itself with parameters, resource & outputs
    • Azure DevOps pipeline & GitHub workflow
    • Extension code such as
      • Diagnostic Settings
      • RBAC
      • Locks
      • Private Endpoints

  • A generated module AVS PrivateCloud

  • Out of scope in this version

    • Child-Modules
    • Idempotency

This is the result of a joined effort by @krbar @shrivastavarashmi @georgedobrin @prteotia and @MrMCake

TODO:

  • Create ReadMe
  • Finish documentation
  • Create Test Pipeline

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

AlexanderSehr and others added 30 commits September 19, 2022 10:35
@AlexanderSehr
Added dummy REST Fetch script
95c7112
@AlexanderSehr
Update to latest
4dc71b3
@AlexanderSehr
Update to latest
ff53765
@AlexanderSehr
Added PGtypes function
fb2c770
@krbar
Get-ModuleDataRestApiSpecs intial file skeleton
2a3f5ab
@prteotia
created new file for adding module structure
edd5b22 
Generates module structure
@AlexanderSehr
Update to latest
f21b22a
@AlexanderSehr
Removed repo
77f7807
@krbar
Getting all resource paths with a put method
178c66f
@krbar
Cleaning output
bc343f3
@AlexanderSehr
Extended folder & file creation structure (#2069)
7bd15e7 
* Latest draft

* Added additional files

* Formatted functions

* Update to latest

* Update to latest
@AlexanderSehr
Added RoleDef template
0365c62
@georgedobrin
Update Get-ModuleDataRestApiSpecs.ps1
962dc8e
@AlexanderSehr
Added diagnostic settings fetch + added template generation script
e38bada
@AlexanderSehr
Cleanup
13d2721
@krbar
Get-ModuleDataSource function
b2788ec
@krbar
Merge branch 'users/hack-REST2CARML' of https://github.com/Azure/Reso…
a120d85 
…urceModules into users/hack-REST2CARML
@krbar
adding some temporary debug code (will be removed later)
7997301
@krbar
some debug output, example call modfied
839785d
@AlexanderSehr
Update to latest
4560af2
@georgedobrin
Update Get-ModuleDataRestApiSpecs.ps1
12a11d1
@georgedobrin
Update Get-ModuleDataRestApiSpecs.ps1
8fb58bc
@AlexanderSehr
Updated scripts
9186686
@krbar
Allowing more than one result per resource type
34a5003
@AlexanderSehr
Data mock
88bdd39
@AlexanderSehr
Data mock
f244d58
@AlexanderSehr
Data mock
5827f65
@prteotia
Added file Get-ModuleLockDetail
8f80477 
Checks if lock can be applied on resource or not
@krbar
Renaming Set-ModuleTemplate to Set-Module
c264c14
@krbar
Merge branch 'users/hack-REST2CARML' of https://github.com/Azure/Reso…
fc0b578 
…urceModules into users/hack-REST2CARML
AlexanderSehr and others added 30 commits October 29, 2022 13:46
@AlexanderSehr
Added latest todos & updated AVS
9080dea
@AlexanderSehr
Latest draft
e1a0a8a
@AlexanderSehr
Update to latest
f26e3ec
@AlexanderSehr
Added sorting and the like
0b6319a
@AlexanderSehr
Further refined paramters declaration & sorting
4d8ac3c
@AlexanderSehr
[Utilities] Added extraction function to get template content to enab…
5db2ffd 
…le REST2CARML idempotency (#2256)

* Update to latest

* Update to latest

* Added var extraction

* Added outputs extraction

* Update to latest

* Extended resource extraction function

* Update to latest

* Extended resources evaluation

* Enabled detailed content for modules

* Moved function

* Simplified code

* Added documentation

* Update to latest

* Update to latest
@AlexanderSehr
Users/hack rest2 carml idemp enable (#2257)
47c8308 
* Added sorting

* Added cleanup & adjusted indents

* Additinoal functional updates

* Update to latest

* Update to latest
@AlexanderSehr
Users/hack rest2 carml idemp enable (#2285)
37359eb 
* Added sorting

* Added cleanup & adjusted indents

* Additinoal functional updates

* Update to latest

* Update to latest

* Enabled variable idempotency

* Add regions

* Enabled idempotency for resource deployment

* Added additional logic for idempotency

* Further updates to idempotency

* Fixed typo

* Update to latest

* Update to latest

* Update to latest

* Added loc

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Started extraction

* Refactored a lot of logic into dedicated functions

* Re-generated module

* Improved idempotency

* Added docs

* Updated docs

* Update to latest

* Updated docs + updated module gen

* Updated docs

* Update to latest

* Update to latest
@AlexanderSehr
Update to latest
c5a59fa
@AlexanderSehr
[Utilities] Update REST2CARML to leverage AzureAPICrawler module (#2356)
bb8256f 
* First refactoring to api crawler

* Next bach

* Cleanup

* More updates

* small fixes

* Update to latest

* Update to latest
Merge branch 'main' of https://github.com/Azure/ResourceModules into …
a307030 
…users/hack-REST2CARML
@krbar
Update of pipeline/workflow yml templates
43fbbe9
@krbar
minor fixes: test file names, roles formatting
291fd46
@krbar
Merge branch 'main' of https://github.com/Azure/ResourceModules into …
9c18010 
…users/hack-REST2CARML
Push updated API Specs file
938f2b3
@krbar
Update of pipeline/workflow yml templates
d01fbc3
@krbar
Set-ModuleReadMe: handling empty test files
059e83c
@krbar
Fixing double defaultTelemetry issue
a5107f4
@krbar
making resource's properties parameter conditional
f4b0360
@krbar
Fixing missing and wrong location output
937ec02
@krbar
Fixing last line diffs in additional files on create and update
b1e31fa
@krbar
Fixing Get-TargetScope
cdab7ff
@krbar
Fixing double child parameter issue
13bc300
@krbar
Merge branch 'main' of https://github.com/Azure/ResourceModules into …
aaa906d 
…users/hack-REST2CARML
Push updated API Specs file
e8e8868
@krbar
Merge branch 'main' of https://github.com/Azure/ResourceModules into …
45b1e92 
…users/hack-REST2CARML
@krbar
Set-ModuleReadme - updated to latest
7970d03
@krbar
apiSpecList - updated to latest
7fb1122
@krbar
Set-ModuleReadMe: handling empty test files (repeating after main merge)
a75fa68
@krbar
Merge branch 'main' of https://github.com/Azure/ResourceModules into …
847a40a 
…users/hack-REST2CARML
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AlexanderSehr AlexanderSehr

Labels
hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: REST2CARML PoC
5 participants
@AlexanderSehr @krbar @prteotia @georgedobrin @shrivastavarashmi