Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): Standarize workflow id when resolving resource #5422

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented Aug 16, 2024

This pull request includes changes to the LogicAppResolver class in the apps/vs-code-designer/src/LogicAppResolver.ts file. The main focus of these changes is to ensure that workflow IDs are consistently handled in a case-insensitive manner by converting them to lowercase.

  • Modified the listOfSites.forEach loop to convert item.id to lowercase before setting it in subscriptionSites.
  • Added conversion of resource.id to lowercase in getAppResourceSite method to ensure consistent key retrieval from logicAppsSites and subscriptionSites.
    Fixes Cannot access logic apps (Internal Error) #4929

@ccastrotrejo ccastrotrejo enabled auto-merge (squash) August 16, 2024 18:34
@ccastrotrejo ccastrotrejo merged commit cdc5006 into main Aug 16, 2024
13 checks passed
@ccastrotrejo ccastrotrejo deleted the ccastrotrejo/resourceResolve branch August 16, 2024 18:42
ccastrotrejo added a commit that referenced this pull request Aug 16, 2024
ccastrotrejo added a commit that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot access logic apps (Internal Error)
2 participants