Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Adventure Works RI Networking Information #590

Merged
merged 10 commits into from
May 27, 2021
Merged

Update Adventure Works RI Networking Information #590

merged 10 commits into from
May 27, 2021

Conversation

jtracey93
Copy link
Collaborator

This PR fixes

@jtracey93 jtracey93 changed the title Eslz aw hub spoke docs Update Adventure Works RI Networking Information May 26, 2021
@jtracey93 jtracey93 requested a review from victorar May 26, 2021 09:32
@jtracey93 jtracey93 added documentation Improvements or additions to documentation enhancement New feature or request labels May 26, 2021
@jtracey93 jtracey93 linked an issue May 26, 2021 that may be closed by this pull request
Copy link
Contributor

@victorar victorar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution Jack. There is no need to explain how hub and spoke works as that's already documented in multiple other Microsoft articles.

Instead of that, please just add a small diagram for a hub and spoke architecture, such as figure 2 on this article: https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/traditional-azure-networking-topology

And mention that spokes use shared resources in the hub such as ExpressRoute and/or VPN GW, and that transit routing across spokes is achieved by VNet peering, UDR and transit via NVA.

@jtracey93 jtracey93 requested a review from victorar May 26, 2021 10:41
@jtracey93
Copy link
Collaborator Author

Thanks @victorar. Have removed the traffic flow section and included links to all the relevant docs.

Have left the new additional diagram as I think this really helps explain and portray how the networking architecture fits with the Management Groups & Subscription organisation in the wider context of Enterprise Scale 👍

Copy link
Contributor

@victorar victorar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions, Jack.

There is no need for a dedicated section for hub and spoke network topology in this article. Instead, within the introduction or customer profile section, just provide a short blurb of what a hub and spoke network topology is, and provide a simple/generic diagram of a hub and spoke network such as the one I shared previously. Then, you can add a link for further details, as well as design considerations and recommendations for hub and spoke networks in ESLZ: https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/traditional-azure-networking-topology

@jtracey93 jtracey93 requested a review from victorar May 26, 2021 12:14
@jtracey93
Copy link
Collaborator Author

Hey Victor, no problem.

Have made further updates.

Your updates looks great! Here are my proposed updates to the hub and spoke section.
Copy link
Contributor

@victorar victorar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some updates in your fork/branch. Let me know what you think :)

Copy link
Collaborator Author

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good with me 👍

@victorar victorar merged commit 980f973 into Azure:main May 27, 2021
@jtracey93 jtracey93 deleted the eslz-aw-hub-spoke-docs branch May 27, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants