Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remediating RBAC Roles on Assignments #1419

Merged
merged 15 commits into from
Sep 19, 2023

Conversation

Springstone
Copy link
Member

@Springstone Springstone commented Sep 6, 2023

Overview/Summary

  • Remediating default policy/initiative assignments using Owner role to be least privilege where possible. Updated assignments:
    • DINE-ActivityLogPolicyAssignment.json (Management Group: Intermediate Root)
    • DINE-AksPolicyPolicyAssignment.json (added additional required role)
    • DINE-ResourceDiagnosticsPolicyAssignment.json (Management Group: Intermediate Root)
    • DINE-SQLEncryptionPolicyAssignment.json (Management Group: Landing Zone)
    • DINE-VMBackupPolicyAssignment.json (Management Group: Landing Zone)
    • DINE-VMMonitoringPolicyAssignment.json (Management Group: Intermediate Root)
    • DINE-VMSSMonitoringPolicyAssignment.json (Management Group: Intermediate Root)

Addresses user story: AB#30459

This PR fixes/adds/changes/removes

  1. Updates default assignments listed above

Breaking Changes

  1. N/A

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone added this to the policy-refresh-fy24-q1 milestone Sep 6, 2023
@Springstone Springstone added policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments labels Sep 6, 2023
@Springstone Springstone temporarily deployed to csu-rw September 6, 2023 12:56 — with GitHub Actions Inactive
@Springstone Springstone marked this pull request as ready for review September 18, 2023 07:50
@Springstone Springstone requested a review from a team as a code owner September 18, 2023 07:50
@Springstone
Copy link
Member Author

Springstone commented Sep 18, 2023

GTM. Tested and policies remediate as expected.

@Springstone Springstone reopened this Sep 18, 2023
@Springstone Springstone temporarily deployed to csu-rw September 18, 2023 16:07 — with GitHub Actions Inactive
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @Springstone

Just need tests to pass

@Springstone Springstone merged commit 4ceaa70 into Azure:policy-refresh-q1fy24 Sep 19, 2023
5 of 10 checks passed
@Springstone Springstone deleted the RBACAssignments branch January 8, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants