-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remediating RBAC Roles on Assignments #1419
Merged
Springstone
merged 15 commits into
Azure:policy-refresh-q1fy24
from
Springstone:RBACAssignments
Sep 19, 2023
Merged
Remediating RBAC Roles on Assignments #1419
Springstone
merged 15 commits into
Azure:policy-refresh-q1fy24
from
Springstone:RBACAssignments
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Springstone
added
policy
PR: Safe to test 🧪
PRs can run more advanced tests that may deploy or access environments
labels
Sep 6, 2023
Springstone
had a problem deploying
to
csu-rw
September 18, 2023 10:12 — with
GitHub Actions
Failure
…rprise-Scale into RBACAssignments.
Springstone
had a problem deploying
to
csu-rw
September 18, 2023 14:12 — with
GitHub Actions
Failure
Springstone
had a problem deploying
to
csu-rw
September 18, 2023 14:49 — with
GitHub Actions
Failure
GTM. Tested and policies remediate as expected. |
jtracey93
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @Springstone
Just need tests to pass
Springstone
merged commit Sep 19, 2023
4ceaa70
into
Azure:policy-refresh-q1fy24
5 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Owner
role to be least privilege where possible. Updated assignments:Addresses user story: AB#30459
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
Testing URLs
Azure Public
As part of this Pull Request I have
main
branch/docs/wiki/whats-new.md
)