Denyactionpr #1406
Merged
Denyactionpr #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Springstone
added
the
PR: Safe to test 🧪
Springstone
requested changes
Aug 17, 2023
docs/wiki/Whats-new.md
Outdated
| @@ -49,6 +49,10 @@ Major update in this release: introducing the Policy Testing Framework foundatio | |||
| - Deploy-SQL-minTLS | |||
| - Deploy-MySQL-sslEnforcement (changed from Owner to Contributor role, no built in roles currently available) | |||
| - Deploy-PostgreSQL-sslEnforcement (changed from Owner to Contributor role, no built in roles currently available) | |||
| - Additional policy definitions: | |||
There was a problem hiding this comment.
Suggested change
| - Additional policy definitions: | |
| - Adding `DenyAction` policy definitions: |
docs/wiki/Whats-new.md
Outdated
| - Additional policy definitions: | ||
| - `DenyAction-ActivityLogs` | ||
| - `DenyAction-DiagnosticLogs` | ||
| - These two policy definitions prevent Activity Log Settings and Diagnostic Settings being deleted leveraging Azure Policy DenyAction functionality |
There was a problem hiding this comment.
Suggested change
| - These two policy definitions prevent Activity Log Settings and Diagnostic Settings being deleted leveraging Azure Policy DenyAction functionality | |
| - These two policy definitions prevent Activity Log Settings and Diagnostic Settings being deleted leveraging Azure Policy DenyAction functionality | |
| - Additionally including an initiative that includes both `DenyAction` policies |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. |
|
@JamJarchitect & @Springstone are we also looking to add tests for this one? |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. |
|
@Springstone @JamJarchitect - whats the latest with this one? |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. |
Springstone
added a commit
that referenced
this pull request
Sep 18, 2023
This reverts commit bc80050.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Implementation of DenyAction Delete into Azure Landing Zones for both Activity Logs and Diagnostic Settings as two seperate policy definitions and a policy initiative.
Address story AB#29619
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Testing URLs
Azure Public
Azure US Gov (Fairfax)
As part of this Pull Request I have
mainbranch/docs/wiki/whats-new.md)