Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CMK schema, introduced type import & grouped interface files #1737

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Added CMK schema, introduced type import & grouped interface files #1737

merged 4 commits into from
Dec 11, 2024

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 27, 2024 •
edited
Loading

Overview/Summary

Redone version of #1737

image

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner November 27, 2024 21:03
@AlexanderSehr AlexanderSehr self-assigned this Nov 27, 2024
@AlexanderSehr AlexanderSehr added the Type: Documentation 📄 Improvements or additions to documentation label Nov 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 27, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the AVM Issue Triage documentation.

@AlexanderSehr AlexanderSehr mentioned this pull request Nov 28, 2024
Open
@AlexanderSehr AlexanderSehr requested a review from eriqua November 28, 2024 20:26
@AlexanderSehr AlexanderSehr requested a review from eriqua December 10, 2024 10:05
@eriqua eriqua self-assigned this Dec 11, 2024
@eriqua eriqua added Language: Bicep 💪 This is related to the Bicep IaC language and removed Needs: Triage 🔍 Maintainers need to triage still labels Dec 11, 2024
eriqua
eriqua approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 995634f into main Dec 11, 2024
4 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/cmkSpec branch December 11, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

@eriqua eriqua

Labels
Language: Bicep 💪 This is related to the Bicep IaC language Type: Documentation 📄 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderSehr @eriqua