Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm/ptn/security/security-center #802

Closed
2 tasks done
tony-box opened this issue Apr 1, 2024 · 6 comments · Fixed by Azure/bicep-registry-modules#1746
Closed
2 tasks done

[Module Proposal]: avm/ptn/security/security-center #802

tony-box opened this issue Apr 1, 2024 · 6 comments · Fixed by Azure/bicep-registry-modules#1746
Assignees
Labels
Class: Pattern Module 📦 This is a pattern module Language: Bicep 💪 This is related to the Bicep IaC language Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@tony-box
Copy link
Contributor

tony-box commented Apr 1, 2024

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/ptn/security/security-center

Module Details

Azure Security Center

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

tony-box

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@tony-box tony-box added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Apr 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Language: Bicep 💪 This is related to the Bicep IaC language label Apr 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label Apr 1, 2024
@matebarabas matebarabas added Status: In Triage 🔍 Picked up for triaging by an AVM core team member Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Class: Pattern Module 📦 This is a pattern module labels Apr 1, 2024
@matebarabas
Copy link
Contributor

Hi @tony-box,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Apr 1, 2024
@tony-box
Copy link
Contributor Author

tony-box commented Apr 1, 2024

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Apr 1, 2024
@matebarabas
Copy link
Contributor

Hi @tony-box,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - for naming your module
    • TelemetryIdPrefix - for your module's telemetry
  • For your module's repository:
    • Repo name and folder path are defined in RepoURL
    • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
    • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

@matebarabas matebarabas removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Apr 1, 2024
@matebarabas matebarabas moved this from Proposed to In development in AVM - Module Triage Apr 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Apr 23, 2024
@tony-box
Copy link
Contributor Author

developing here: https://github.com/tony-box/bicep-registry-modules/tree/ptn/securitycenter/avm/ptn/security/security-center

Still need to update max tests and get the permissions for the new folder in AVM sorted

@matebarabas matebarabas removed the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Apr 23, 2024
@matebarabas
Copy link
Contributor

@tony-box, for maximum transparency, please submit a draft PR, as soon as possible, even if the module is not fully mature yet. Thanks!

tony-box added a commit to Azure/bicep-registry-modules that referenced this issue Apr 28, 2024
## Description

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.
-->

Migration of ptn/security-center from CARML -> AVM.

Azure/Azure-Verified-Modules#802

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.ptn.security.security-center](https://github.com/tony-box/bicep-registry-modules/actions/workflows/avm.ptn.security.security-center.yml/badge.svg?branch=securitycenter)](https://github.com/tony-box/bicep-registry-modules/actions/workflows/avm.ptn.security.security-center.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [ ] I'm sure there are no other open Pull Requests for the same
update/change
- [ ] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Tony Box <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
@github-project-automation github-project-automation bot moved this from In development to Done in AVM - Module Triage Apr 28, 2024
@matebarabas matebarabas added the Status: Module Available 🟢 The module is published label Apr 29, 2024
@matebarabas
Copy link
Contributor

  • Module published.
  • GitHub teams are available and assigned to their parents.
  • CODEOWNERS file updated.

Thank you for your work @tony-box!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Pattern Module 📦 This is a pattern module Language: Bicep 💪 This is related to the Bicep IaC language Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Development

Successfully merging a pull request may close this issue.

2 participants