-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Module Proposal]: avm/ptn/security/security-center
#802
Comments
Hi @tony-box, Thanks for requesting/proposing to be an AVM module owner! We just want to confirm you agree to the below pages that define what module ownership means: Any questions or clarifications needed, let us know! If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍): "I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER" Thanks, The AVM Core Team #RR |
I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER |
Hi @tony-box, Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities! Before starting development, please ensure ALL the following requirements are met. Please use the following values explicitly as provided in the module index page:
Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍 You can now start the development of this module! ✅ Happy coding! 🎉 Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏 Any further questions or clarifications needed, let us know! Thanks, The AVM Core Team |
developing here: https://github.com/tony-box/bicep-registry-modules/tree/ptn/securitycenter/avm/ptn/security/security-center Still need to update max tests and get the permissions for the new folder in AVM sorted |
@tony-box, for maximum transparency, please submit a draft PR, as soon as possible, even if the module is not fully mature yet. Thanks! |
## Description <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. --> Migration of ptn/security-center from CARML -> AVM. Azure/Azure-Verified-Modules#802 ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [![avm.ptn.security.security-center](https://github.com/tony-box/bicep-registry-modules/actions/workflows/avm.ptn.security.security-center.yml/badge.svg?branch=securitycenter)](https://github.com/tony-box/bicep-registry-modules/actions/workflows/avm.ptn.security.security-center.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [ ] I'm sure there are no other open Pull Requests for the same update/change - [ ] I have run `Set-AVMModule` locally to generate the supporting module files. - [ ] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Tony Box <[email protected]> Co-authored-by: Alexander Sehr <[email protected]>
Thank you for your work @tony-box! |
Check for previous/existing GitHub issues/module proposals
Check this module doesn't already exist in the module indexes
Bicep or Terraform?
Bicep
Module Classification?
Resource Module
Module Name
avm/ptn/security/security-center
Module Details
Azure Security Center
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username (handle)
tony-box
(Optional) Secondary Module Owner's GitHub Username (handle)
No response
The text was updated successfully, but these errors were encountered: