-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Module Proposal]: avm/res/insights/private-link-scope
#511
Comments
Hi @ahmadabdalla, Thanks for requesting/proposing to be an AVM module owner! We just want to confirm you agree to the below pages that define what module ownership means: Any questions or clarifications needed, let us know! If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍): "I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER" Thanks, The AVM Core Team #RR |
I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER |
Hi @ahmadabdalla, Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities! Before starting development, please ensure ALL the following requirements are met. Please use the following values explicitly as provided in the module index page:
Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍 You can now start the development of this module! ✅ Happy coding! 🎉 Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏 Any further questions or clarifications needed, let us know! Thanks, The AVM Core Team |
@ahmadabdalla, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module. |
## Description Closes Azure/Azure-Verified-Modules#511 Closes Azure/ResourceModules#4416 ### Pipeline [![avm.res.insights.private-link-scope](https://github.com/ahmadabdalla/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml/badge.svg?branch=users%2Fahmad%2F4413_privateLinkScopes)](https://github.com/ahmadabdalla/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml) ### Teams ![image](https://github.com/Azure/bicep-registry-modules/assets/28486158/effb9699-a9e8-46f1-93c8-a13741ccf81e) ![image](https://github.com/Azure/bicep-registry-modules/assets/28486158/4310b327-21bf-4dc2-9122-01acfb7c90c3) <!--Why this PR? What is changed? What is the effect? etc.--> If you haven't already, read the full [contribution guide](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md). The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, edit the PR description and run through the relevant checklist below. Enable GitHub Workflows in your fork to enable auto-generation of assets with our [GitHub Action](/.github/workflows/push-auto-generate.yml). To trigger GitHub Actions after auto-generation, [add a GitHub PAT](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token) as a secret in your forked repository called `PAT`. ## Adding a new module <!--Run through the checklist if your PR adds a new module.--> - [x] A proposal has been submitted and approved. - [x] I have included "Closes #{module_proposal_issue_number}" in the PR description. - [x] I have run `brm validate` locally to verify the module files. - [x] I have run deployment tests locally to ensure the module is deployable. ## Updating an existing module <!--Run through the checklist if your PR updates an existing module.--> - [ ] This is a bug fix: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] I have run `brm validate` locally to verify the module files. - [ ] I have run deployment tests locally to ensure the module is deployable. - [ ] I have read the [Updating an existing module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module) section in the contributing guide and updated the `version.json` file properly: - [ ] The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`. - [ ] The PR contains backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] The PR contains breaking changes, and I have bumped the MAJOR version in `version.json`. - [ ] I have updated the examples in README with the latest module version number. --------- Co-authored-by: Alexander Sehr <[email protected]> Co-authored-by: Erika Gressi <[email protected]>
Thank you for your work @ahmadabdalla! |
Check for previous/existing GitHub issues/module proposals
Check this module doesn't already exist in the module indexes
Bicep or Terraform?
Bicep
Module Classification?
Resource Module
Module Name
avm/res/insights/private-link-scope
Module Details
Migration from CARML
https://github.com/ahmadabdalla/bicep-registry-modules/tree/users/ahmad/4413_privateLinkScopes
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username (handle)
ahmadabdalla
(Optional) Secondary Module Owner's GitHub Username (handle)
No response
The text was updated successfully, but these errors were encountered: