Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm/res/insights/private-link-scope #511

Closed
2 tasks done
ahmadabdalla opened this issue Jan 7, 2024 · 5 comments · Fixed by Azure/bicep-registry-modules#873
Closed
2 tasks done
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@ahmadabdalla
Copy link
Contributor

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/insights/private-link-scope

Module Details

Migration from CARML
https://github.com/ahmadabdalla/bicep-registry-modules/tree/users/ahmad/4413_privateLinkScopes

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

ahmadabdalla

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@ahmadabdalla ahmadabdalla added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Jan 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Language: Bicep 💪 This is related to the Bicep IaC language label Jan 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label Jan 7, 2024
@matebarabas matebarabas added Status: In Triage 🔍 Picked up for triaging by an AVM core team member Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Class: Resource Module 📦 This is a resource module labels Jan 9, 2024
@matebarabas
Copy link
Contributor

Hi @ahmadabdalla,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Jan 9, 2024
@ahmadabdalla
Copy link
Contributor Author

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Jan 11, 2024
@matebarabas matebarabas removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Jan 11, 2024
@matebarabas matebarabas moved this from Proposed to In development in AVM - Module Triage Jan 11, 2024
@matebarabas
Copy link
Contributor

Hi @ahmadabdalla,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - for naming your module
    • TelemetryIdPrefix - for your module's telemetry
  • For your module's repository:
    • Repo name and folder path are defined in RepoURL
    • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
    • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

@ahmadabdalla, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Feb 1, 2024
@matebarabas matebarabas added the Status: In PR 👉 This is when an issue is due to be fixed in an open PR label Feb 3, 2024
@matebarabas matebarabas moved this from In development to In Review in AVM - Module Triage Feb 3, 2024
@matebarabas matebarabas removed the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Feb 3, 2024
ahmadabdalla added a commit to Azure/bicep-registry-modules that referenced this issue Feb 6, 2024
## Description

Closes Azure/Azure-Verified-Modules#511

Closes Azure/ResourceModules#4416

### Pipeline


[![avm.res.insights.private-link-scope](https://github.com/ahmadabdalla/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml/badge.svg?branch=users%2Fahmad%2F4413_privateLinkScopes)](https://github.com/ahmadabdalla/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml)

### Teams


![image](https://github.com/Azure/bicep-registry-modules/assets/28486158/effb9699-a9e8-46f1-93c8-a13741ccf81e)


![image](https://github.com/Azure/bicep-registry-modules/assets/28486158/4310b327-21bf-4dc2-9122-01acfb7c90c3)


<!--Why this PR? What is changed? What is the effect? etc.-->

If you haven't already, read the full [contribution
guide](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md).
The guide may have changed since the last time you read it, so please
double-check. Once you are done and ready to submit your PR, edit the PR
description and run through the relevant checklist below.

Enable GitHub Workflows in your fork to enable auto-generation of assets
with our [GitHub Action](/.github/workflows/push-auto-generate.yml).
To trigger GitHub Actions after auto-generation, [add a GitHub
PAT](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token)
as a secret in your forked repository called `PAT`.

## Adding a new module

<!--Run through the checklist if your PR adds a new module.-->

- [x] A proposal has been submitted and approved.
- [x] I have included "Closes #{module_proposal_issue_number}" in the PR
description.
- [x] I have run `brm validate` locally to verify the module files.
- [x] I have run deployment tests locally to ensure the module is
deployable.

## Updating an existing module

<!--Run through the checklist if your PR updates an existing module.-->

- [ ] This is a bug fix:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] I have run `brm validate` locally to verify the module files.
- [ ] I have run deployment tests locally to ensure the module is
deployable.
- [ ] I have read the [Updating an existing
module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module)
section in the contributing guide and updated the `version.json` file
properly:
- [ ] The PR contains backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`.
- [ ] The PR contains backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] The PR contains breaking changes, and I have bumped the MAJOR
version in `version.json`.
- [ ] I have updated the examples in README with the latest module
version number.

---------

Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Erika Gressi <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in AVM - Module Triage Feb 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Status: In PR 👉 This is when an issue is due to be fixed in an open PR label Feb 6, 2024
@matebarabas matebarabas added the Status: Module Available 🟢 The module is published label Feb 7, 2024
@matebarabas
Copy link
Contributor

  • Module published.
  • GitHub teams are available and assigned to their parents.
  • CODEOWNERS file updated.

Thank you for your work @ahmadabdalla!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Development

Successfully merging a pull request may close this issue.

2 participants