Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TrendMicro] Roll back deploy script name for aka.ms url. #4149

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

trend-adam-c-huang
Copy link
Contributor

Required items, please complete

Change(s):

  • Updated azuredeploy_TrendMicroVisionOne_API_FunctionApp.json file name.

Reason for Change(s):

  • Since aka.me point to old naming. Roll back to old file name.

Version Updated:

  • No

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@trend-adam-c-huang trend-adam-c-huang marked this pull request as ready for review February 11, 2022 05:27
@v-marimanda v-marimanda added the Solution Solution specialty review needed label Mar 1, 2022
@NikTripathi NikTripathi merged commit 67cdf32 into Azure:master Mar 2, 2022
@trend-adam-c-huang
Copy link
Contributor Author

Hi @NikTripathi
Sorry to have a question:
My aka.ms link still link to pre file name (azuredeploy_TrendMicroXDR.json),
How do I change it?
Thank you.
Best regards

@NikTripathi
Copy link
Contributor

Hi @NikTripathi Sorry to have a question: My aka.ms link still link to pre file name (azuredeploy_TrendMicroXDR.json), How do I change it? Thank you. Best regards

Hi @adamhuang97 I have updated the links. Can you please checkout if it is correct or not? Thanks

@trend-adam-c-huang
Copy link
Contributor Author

Hi @NikTripathi,
Thanks for your help.
It works now.

Thank you.
Best regards

@trend-adam-c-huang
Copy link
Contributor Author

Hi @NikTripathi ,
Sorry to bother you.
We have a parameter issue not sync to this pr.
Would you please help to review it on #4298 ?

Thank you so much.
Best regards,
Adam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants