-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Silverfort Solution #10941
Added Silverfort Solution #10941
Conversation
Hello @FrankGasparovic, Please add input file which should be in Data folder. It is needed to package the solution. Also add workbook metadata to this file Analytic rules are missing with entity mappings, techniques and tactics. Please do share sample data to test the content of the solution. |
Also I have one doubt. Is this Solution Microsoft supported. We haven't received any instructions for the same. |
@v-prasadboke The PR has been updated based on your feedback. Please let me know if there is anything else needed. |
2a645b3
to
ff8a4a5
Compare
"graphQueries": [ | ||
{ | ||
"metricName": "Total data received", | ||
"legend": "DATATYPE_NAME", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace DATA_TYPE name with data type.
You can refer to this Connector for more clarification
https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/OneIdentity/Data%20Connectors/OneIdentity.JSON
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
Logos/silverfort-logo.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logo size should be below 5kb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
@@ -0,0 +1,15 @@ | |||
{ | |||
"publisherId": "silverfort5120441444412", | |||
"offerId": "silverfort", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
Hello @FrankGasparovic, Thanks for committing the required changes. We will get back to you by 28 August, 2024. |
Hi @v-prasadboke, I wanted to check on on the current status of the PR? |
Hello @FrankGasparovic, Please update the branch from master. Also if possible can you please try to provide me write access to your branch. Need to push some required commits |
@v-prasadboke I have pulled in the latest upstream changes. I unfortunately can not give you write permissions on our forked repository. Can you please provide me the files you need to add or replace? Feel free to email me at [email protected] with the zip. |
Hello @FrankGasparovic, We want you package the solution using V3 tool. Also add release notes to the solution. Release notes reference - https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/IPinfo/ReleaseNotes.md |
@v-prasadboke The solution has been packaged with v3 and we have added release notes |
Hello @FrankGasparovic, Can you please try to resolve failing validation errors |
@v-prasadboke All checks have been resolved |
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: