-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPinfo Sentinel Solution #10553
IPinfo Sentinel Solution #10553
Conversation
@microsoft-github-policy-service agree company="IPinfo" |
Hello @AhmadMujahid2k, Please provide publisher and offer ID so that we can test the content of the Solution. |
Hi @v-prasadboke, |
Please replace underscore '_' with hyphen '-' in offer id |
Solutions/IPinfo/Data Connectors/Company/IPinfo_Company_API_AzureFunctionApp.json
Outdated
Show resolved
Hide resolved
Sure, we will update the offer ID shortly. |
Thank you for the confirmation @AhmadMujahid2k |
@v-prasadboke apologies for delay. Offer ID: microsoft-sentinel-solution-ipinfo-ipintelligence |
Thanks for updating the offer id. I'll continue the investigation. Until then can you share the invocation logs of the function app |
These are the invocation logs for the "Company" function app. The other two function apps "IP-location" and "Privacy" share similar functionality and configurations but utilize different datasets: |
Thanks @AhmadMujahid2k, the zip's folder structure is not correct. Also seems some files are missing. I'll take a look at it once and confirm on it. Thanks. Until then can you please resolve validation failures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @AhmadMujahid2k, if this is the main function app file
please rename it to main.py
you can refer this data connector for more clarification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @v-prasadboke
We use the V2 method, creating function_app.py as per documentation. We also see a similar in the "WithSecureElementsViaFunction" solution. We'll rename it to main.py if needed. No specific data connector was mentioned by you above was this an oversight?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @AhmadMujahid2k my Bad, missed on adding the hyperlink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @v-prasadboke could you please clarify if we need the function.json file to specify the time for running main.py, given that this is the v1 method? We are currently following the v2 method, in which the schedule is defined in function_app.py.
We are a bit confused and need clarification on whether you want us to follow the exact structure of the data connector you provided or if there is some flexibility.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @AhmadMujahid2k, can we connect for the same to clarify the requirements.
We can get on a call. Please share your availability and time zone so that we can plan for the same.
Please do share you mail id too.
If needed you can ping me on teams too. My mail and teams id is [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @v-prasadboke Thank you for considering the meeting. We will be available from Monday to Friday, from 6:00 AM UTC to 1:00 PM UTC.
Our email addresses are:
[email protected]
[email protected]
Looking forward to connecting with you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @AhmadMujahid2k can we connect on 4 July, 2024 at 10:00 Am UTC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@v-prasadboke that's perfect! We are available.
Looking forward to it!
Hello @AhmadMujahid2k as discussed in the call. Please proceed with the changes requested. Thanks. |
@v-prasadboke invocation logs for the "Company" & "Privacy" function app. |
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
[-] IDs Should Be Derived From ResourceIDs (125 ms)
Property: "id" must use one of the following expressions for an resourceId property: extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid