-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPinfo Sentinel Solution New Connectors #10981
base: master
Are you sure you want to change the base?
Conversation
These are the invocation logs: WHOIS NET.csv |
Hello @AhmadMujahid2k, Thanks for raising this PR. This PR will be investigated and we will update you about the same before 29 August, 2024 |
Invocation log for new Country+ASN data connector. |
@v-prasadboke could you provide an update whether you need any changes from us (IPinfo)? I will be continuing @AhmadMujahid2k's work moving forward. Thank you! |
Hello @AhmadMujahid2k & @max-ipinfo sorry for the late response. Had some priority tasks on my name. We recommend you to upgrade the python version to 3.11 as 3.8 is deprecated and 3.9 & 3.10 will be deprecated soon |
e4cefc2
to
4ab1e11
Compare
I updated all references to Python to version 3.11: 4ab1e11 @v-prasadboke are there any other remaining steps you would like me to perform? |
@v-prasadboke could you provide an update? We are blocked on this PR to release our Solution offering to our customers. Thank you. |
Hello @AhmadMujahid2k |
@v-prasadboke regarding your error, I was trying to address your comment asking us to upgrade to Python 3.11. All I did in 4ab1e11 is changing I am unfortunately not up-to-speed with how to test a Sentinel Solution:
Thanks! |
I went through the docs: I see that
That's the version set everywhere as far as I can tell:
|
|
Hello @AhmadMujahid2k, Please provide your update on the above |
Hello @AhmadMujahid2k, We are waiting for your feedback |
@max-ipinfo is leading this PR. Max, please update @v-prasadboke on the status of the PR, please. |
@max-ipinfo, If possible can you provide us some update on this |
Hello @AhmadMujahid2k & @max-ipinfo can you provide us some update on this |
We wanted to check on the status of PR #10981 . PR is pending for more than 45+ days. Please let us know if you need any assistance to review this PR. Per our standard operating procedures if no response is received in the next 7 business days, we will close this PR. Thank you for your cooperation. |
@v-prasadboke thank you for your message. We would definitely need assistance getting this PR moving again. Last time I tried, I wasn't able to easily follow your instructions to debug the Python version error you were getting. So we've stuck unable to move it forward. Any support on your side would be helpful @v-prasadboke . Thank you! |
@v-prasadboke I just wanted to let you know that the IPinfo team had a deep-dive call with the Microsoft Sentinel team on Friday December 6, and it gave us great insight into the Sentinel Platform. I am hoping to make progress on the PR this week. Thank you for your patience! |
Thanks for the update @max-ipinfo |
Hello @max-ipinfo, Do we have any update here |
Hello @AhmadMujahid2k Can you provide us an update or probably any ETA |
Hello @v-prasadboke, sorry for my late reply. I was OOO for the holidays. I am still working on testing our Sentinel Solution in Azure. Fortunately, I will have some time to continue my testing in the upcoming days and expect to provide a concrete update this week. Thank you for your patience. |
@v-prasadboke I was able to test the deployment of one Data Connector Azure Function to Azure with Python 3.11 without any problem. Here is what I did:
Here is the proof from my end: Can you elaborate what are the remaining issues you would need us to handle? |
Hey thanks for the update @max-ipinfo, i'll take a look at this. Also can you share invocation logs for the same. Head to functions tab, click on function and you will have option for the logs. Thanks, |
Any manual call that I make to the Azure Function (following the instructions on https://learn.microsoft.com/en-us/azure/azure-functions/functions-manually-run-non-http) do not do anything or show any logs or invocations:
I have spent the whole day trying to debug this without making progress. How do you trigger the Azure Function in your test environment? How do you connect your Sentinel workspace fo these manually created Azure Functions used for Data Connectors? |
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
[-] IDs Should Be Derived From ResourceIDs (125 ms)
Property: "id" must use one of the following expressions for an resourceId property: extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid